mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v1 Resend] usb: dwc2: gadget: fix a memory use-after-free bug
@ 2015-09-29 10:25 Mian Yousaf Kaukab
       [not found] ` <CAOZ-Yot=qFZKrcCcPAsKdpDMT58_kPJ68sPaSKngF8dG+5ZDSg@mail.gmail.com>
  0 siblings, 1 reply; 4+ messages in thread
From: Mian Yousaf Kaukab @ 2015-09-29 10:25 UTC (permalink / raw)
  To: linux-usb, balbi, john.youn, lyz
  Cc: heiko, cf, hl, yk, gauravsh, alberto, wulf, jwerner, jeffy.chen,
	gregory.herrero, huangtao, rockchip-discuss, gregkh,
	linux-kernel

From: Yunzhi Li <lyz@rock-chips.com>

When dwc2_hsotg_handle_unaligned_buf_complete() hs_req->req.buf
already destroyed, in dwc2_hsotg_unmap_dma(), it touches
hs_req->req.dma again, so dwc2_hsotg_unmap_dma() should be called
before dwc2_hsotg_handle_unaligned_buf_complete(). Otherwise, it
will cause a bad_page BUG, when allocate this memory page next
time.

This bug led to the following crash:

BUG: Bad page state in process swapper/0  pfn:2bdbc
[   26.820440] page:eed76780 count:0 mapcount:0 mapping:  (null) index:0x0
[   26.854710] page flags: 0x200(arch_1)
[   26.885836] page dumped because: PAGE_FLAGS_CHECK_AT_PREP flag set
[   26.919179] bad because of flags:
[   26.948917] page flags: 0x200(arch_1)
[   26.979100] Modules linked in:
[   27.008401] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W3.14.0 #17
[   27.041816] [<c010e1f8>] (unwind_backtrace) from [<c010a704>] (show_stack+0x20/0x24)
[   27.076108] [<c010a704>] (show_stack) from [<c087eea8>] (dump_stack+0x70/0x8c)
[   27.110246] [<c087eea8>] (dump_stack) from [<c01ce0b8>] (bad_page+0xfc/0x12c)
[   27.143958] [<c01ce0b8>] (bad_page) from [<c01ce65c>] (get_page_from_freelist+0x3e4/0x50c)
[   27.179298] [<c01ce65c>] (get_page_from_freelist) from [<c01ce9a0>] (__alloc_pages_nodemask)
[   27.216296] [<c01ce9a0>] (__alloc_pages_nodemask) from [<c01cf00c>] (__get_free_pages+0x20/)
[   27.252326] [<c01cf00c>] (__get_free_pages) from [<c01e5bec>] (kmalloc_order_trace+0x34/0xa)
[   27.288295] [<c01e5bec>] (kmalloc_order_trace) from [<c0203304>] (__kmalloc+0x40/0x1ac)
[   27.323751] [<c0203304>] (__kmalloc) from [<c052abc0>] (dwc2_hsotg_ep_queue.isra.12+0x7c/0x1)
[   27.359937] [<c052abc0>] (dwc2_hsotg_ep_queue.isra.12) from [<c052af88>] (dwc2_hsotg_ep_queue)
[   27.397478] [<c052af88>] (dwc2_hsotg_ep_queue_lock) from [<c0554110>] (rx_submit+0xfc/0x164)
[   27.433619] [<c0554110>] (rx_submit) from [<c05546e8>] (rx_complete+0x22c/0x230)
[   27.468872] [<c05546e8>] (rx_complete) from [<c052b528>] (dwc2_hsotg_complete_request+0xfc/0)
[   27.506240] [<c052b528>] (dwc2_hsotg_complete_request) from [<c052bba0>] (dwc2_hsotg_handle_o)
[   27.545401] [<c052bba0>] (dwc2_hsotg_handle_outdone) from [<c052be70>] (dwc2_hsotg_epint+0x2c)
[   27.583689] [<c052be70>] (dwc2_hsotg_epint) from [<c052c750>] (dwc2_hsotg_irq+0x1dc/0x4ac)
[   27.621041] [<c052c750>] (dwc2_hsotg_irq) from [<c01682e0>] (handle_irq_event_percpu+0x70/0x)
[   27.659066] [<c01682e0>] (handle_irq_event_percpu) from [<c01684ec>] (handle_irq_event+0x4c)
[   27.697322] [<c01684ec>] (handle_irq_event) from [<c016bae0>] (handle_fasteoi_irq+0xc8/0x11)
[   27.735451] [<c016bae0>] (handle_fasteoi_irq) from [<c0167b8c>] (generic_handle_irq+0x30/0x)
[   27.773918] [<c0167b8c>] (generic_handle_irq) from [<c0167ca4>] (__handle_domain_irq+0x84/0)
[   27.812018] [<c0167ca4>] (__handle_domain_irq) from [<c01003b0>] (gic_handle_irq+0x48/0x6c)
[   27.849695] [<c01003b0>] (gic_handle_irq) from [<c010b340>] (__irq_svc+0x40/0x50)
[   27.886907] Exception stack(0xc0d01ee0 to 0xc0d01f28)

Acked-by: John Youn <johnyoun@synopsys.com>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Yunzhi Li <lyz@rock-chips.com>
---
Resending on Yunzhi's behalf since he is travelling.

 drivers/usb/dwc2/gadget.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 12ac879..5755e65 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -1390,14 +1390,14 @@ static void dwc2_hsotg_complete_request(struct dwc2_hsotg *hsotg,
 	if (hs_req->req.status == -EINPROGRESS)
 		hs_req->req.status = result;
 
+	if (using_dma(hsotg))
+		dwc2_hsotg_unmap_dma(hsotg, hs_ep, hs_req);
+
 	dwc2_hsotg_handle_unaligned_buf_complete(hsotg, hs_ep, hs_req);
 
 	hs_ep->req = NULL;
 	list_del_init(&hs_req->queue);
 
-	if (using_dma(hsotg))
-		dwc2_hsotg_unmap_dma(hsotg, hs_ep, hs_req);
-
 	/*
 	 * call the complete request with the locks off, just in case the
 	 * request tries to queue more work for this endpoint.
-- 
2.3.3


^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH v1 Resend] usb: dwc2: gadget: fix a memory use-after-free bug
       [not found] ` <CAOZ-Yot=qFZKrcCcPAsKdpDMT58_kPJ68sPaSKngF8dG+5ZDSg@mail.gmail.com>
@ 2015-10-01 12:01   ` Kaukab, Yousaf
  2015-10-01 17:21     ` Felipe Balbi
  0 siblings, 1 reply; 4+ messages in thread
From: Kaukab, Yousaf @ 2015-10-01 12:01 UTC (permalink / raw)
  To: balbi
  Cc: linux-usb, john.youn, lyz, heiko, cf, hl, yk, gauravsh, alberto,
	wulf, jwerner, jeffy.chen, Herrero, Gregory, huangtao,
	rockchip-discuss, gregkh, linux-kernel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 4221 bytes --]

> From: Mian Yousaf Kaukab <yousaf.kaukab@intel.com>
> Date: Tue, Sep 29, 2015 at 12:25 PM
> Subject: [PATCH v1 Resend] usb: dwc2: gadget: fix a memory use-after-free bug
> To: linux-usb@vger.kernel.org, balbi@ti.com, john.youn@synopsys.com,
> lyz@rock-chips.com
> Cc: heiko@sntech.de, cf@rock-chips.com, hl@rock-chips.com, yk@rock-
> chips.com, gauravsh@google.com, alberto@google.com, wulf@rock-chips.com,
> jwerner@chromium.org, jeffy.chen@rock-chips.com,
> gregory.herrero@intel.com, huangtao@rock-chips.com, rockchip-
> discuss@chromium.org, gregkh@linuxfoundation.org, linux-
> kernel@vger.kernel.org
> 
> 
> From: Yunzhi Li <lyz@rock-chips.com>
> 
> When dwc2_hsotg_handle_unaligned_buf_complete() hs_req->req.buf already
> destroyed, in dwc2_hsotg_unmap_dma(), it touches hs_req->req.dma again, so
> dwc2_hsotg_unmap_dma() should be called before
> dwc2_hsotg_handle_unaligned_buf_complete(). Otherwise, it will cause a
> bad_page BUG, when allocate this memory page next time.
> 
> This bug led to the following crash:
> 
> BUG: Bad page state in process swapper/0  pfn:2bdbc
> [   26.820440] page:eed76780 count:0 mapcount:0 mapping:  (null) index:0x0
> [   26.854710] page flags: 0x200(arch_1)
> [   26.885836] page dumped because: PAGE_FLAGS_CHECK_AT_PREP flag set
> [   26.919179] bad because of flags:
> [   26.948917] page flags: 0x200(arch_1)
> [   26.979100] Modules linked in:
> [   27.008401] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W3.14.0 #17
> [   27.041816] [<c010e1f8>] (unwind_backtrace) from [<c010a704>]
> (show_stack+0x20/0x24)
> [   27.076108] [<c010a704>] (show_stack) from [<c087eea8>]
> (dump_stack+0x70/0x8c)
> [   27.110246] [<c087eea8>] (dump_stack) from [<c01ce0b8>]
> (bad_page+0xfc/0x12c)
> [   27.143958] [<c01ce0b8>] (bad_page) from [<c01ce65c>]
> (get_page_from_freelist+0x3e4/0x50c)
> [   27.179298] [<c01ce65c>] (get_page_from_freelist) from [<c01ce9a0>]
> (__alloc_pages_nodemask)
> [   27.216296] [<c01ce9a0>] (__alloc_pages_nodemask) from [<c01cf00c>]
> (__get_free_pages+0x20/)
> [   27.252326] [<c01cf00c>] (__get_free_pages) from [<c01e5bec>]
> (kmalloc_order_trace+0x34/0xa)
> [   27.288295] [<c01e5bec>] (kmalloc_order_trace) from [<c0203304>]
> (__kmalloc+0x40/0x1ac)
> [   27.323751] [<c0203304>] (__kmalloc) from [<c052abc0>]
> (dwc2_hsotg_ep_queue.isra.12+0x7c/0x1)
> [   27.359937] [<c052abc0>] (dwc2_hsotg_ep_queue.isra.12) from
> [<c052af88>] (dwc2_hsotg_ep_queue)
> [   27.397478] [<c052af88>] (dwc2_hsotg_ep_queue_lock) from
> [<c0554110>] (rx_submit+0xfc/0x164)
> [   27.433619] [<c0554110>] (rx_submit) from [<c05546e8>]
> (rx_complete+0x22c/0x230)
> [   27.468872] [<c05546e8>] (rx_complete) from [<c052b528>]
> (dwc2_hsotg_complete_request+0xfc/0)
> [   27.506240] [<c052b528>] (dwc2_hsotg_complete_request) from
> [<c052bba0>] (dwc2_hsotg_handle_o)
> [   27.545401] [<c052bba0>] (dwc2_hsotg_handle_outdone) from
> [<c052be70>] (dwc2_hsotg_epint+0x2c)
> [   27.583689] [<c052be70>] (dwc2_hsotg_epint) from [<c052c750>]
> (dwc2_hsotg_irq+0x1dc/0x4ac)
> [   27.621041] [<c052c750>] (dwc2_hsotg_irq) from [<c01682e0>]
> (handle_irq_event_percpu+0x70/0x)
> [   27.659066] [<c01682e0>] (handle_irq_event_percpu) from
> [<c01684ec>] (handle_irq_event+0x4c)
> [   27.697322] [<c01684ec>] (handle_irq_event) from [<c016bae0>]
> (handle_fasteoi_irq+0xc8/0x11)
> [   27.735451] [<c016bae0>] (handle_fasteoi_irq) from [<c0167b8c>]
> (generic_handle_irq+0x30/0x)
> [   27.773918] [<c0167b8c>] (generic_handle_irq) from [<c0167ca4>]
> (__handle_domain_irq+0x84/0)
> [   27.812018] [<c0167ca4>] (__handle_domain_irq) from [<c01003b0>]
> (gic_handle_irq+0x48/0x6c)
> [   27.849695] [<c01003b0>] (gic_handle_irq) from [<c010b340>]
> (__irq_svc+0x40/0x50)
> [   27.886907] Exception stack(0xc0d01ee0 to 0xc0d01f28)
> 
> Acked-by: John Youn <johnyoun@synopsys.com>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> Tested-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Signed-off-by: Yunzhi Li <lyz@rock-chips.com>

Hi Felipe,
This patch has been hanging around for a while now. Can you please apply this?

BR,
Yousaf
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v1 Resend] usb: dwc2: gadget: fix a memory use-after-free bug
  2015-10-01 12:01   ` Kaukab, Yousaf
@ 2015-10-01 17:21     ` Felipe Balbi
  2015-10-02  7:09       ` Kaukab, Yousaf
  0 siblings, 1 reply; 4+ messages in thread
From: Felipe Balbi @ 2015-10-01 17:21 UTC (permalink / raw)
  To: Kaukab, Yousaf
  Cc: balbi, linux-usb, john.youn, lyz, heiko, cf, hl, yk, gauravsh,
	alberto, wulf, jwerner, jeffy.chen, Herrero, Gregory, huangtao,
	rockchip-discuss, gregkh, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 4515 bytes --]

On Thu, Oct 01, 2015 at 12:01:48PM +0000, Kaukab, Yousaf wrote:
> > From: Mian Yousaf Kaukab <yousaf.kaukab@intel.com>
> > Date: Tue, Sep 29, 2015 at 12:25 PM
> > Subject: [PATCH v1 Resend] usb: dwc2: gadget: fix a memory use-after-free bug
> > To: linux-usb@vger.kernel.org, balbi@ti.com, john.youn@synopsys.com,
> > lyz@rock-chips.com
> > Cc: heiko@sntech.de, cf@rock-chips.com, hl@rock-chips.com, yk@rock-
> > chips.com, gauravsh@google.com, alberto@google.com, wulf@rock-chips.com,
> > jwerner@chromium.org, jeffy.chen@rock-chips.com,
> > gregory.herrero@intel.com, huangtao@rock-chips.com, rockchip-
> > discuss@chromium.org, gregkh@linuxfoundation.org, linux-
> > kernel@vger.kernel.org
> > 
> > 
> > From: Yunzhi Li <lyz@rock-chips.com>
> > 
> > When dwc2_hsotg_handle_unaligned_buf_complete() hs_req->req.buf already
> > destroyed, in dwc2_hsotg_unmap_dma(), it touches hs_req->req.dma again, so
> > dwc2_hsotg_unmap_dma() should be called before
> > dwc2_hsotg_handle_unaligned_buf_complete(). Otherwise, it will cause a
> > bad_page BUG, when allocate this memory page next time.
> > 
> > This bug led to the following crash:
> > 
> > BUG: Bad page state in process swapper/0  pfn:2bdbc
> > [   26.820440] page:eed76780 count:0 mapcount:0 mapping:  (null) index:0x0
> > [   26.854710] page flags: 0x200(arch_1)
> > [   26.885836] page dumped because: PAGE_FLAGS_CHECK_AT_PREP flag set
> > [   26.919179] bad because of flags:
> > [   26.948917] page flags: 0x200(arch_1)
> > [   26.979100] Modules linked in:
> > [   27.008401] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W3.14.0 #17
> > [   27.041816] [<c010e1f8>] (unwind_backtrace) from [<c010a704>]
> > (show_stack+0x20/0x24)
> > [   27.076108] [<c010a704>] (show_stack) from [<c087eea8>]
> > (dump_stack+0x70/0x8c)
> > [   27.110246] [<c087eea8>] (dump_stack) from [<c01ce0b8>]
> > (bad_page+0xfc/0x12c)
> > [   27.143958] [<c01ce0b8>] (bad_page) from [<c01ce65c>]
> > (get_page_from_freelist+0x3e4/0x50c)
> > [   27.179298] [<c01ce65c>] (get_page_from_freelist) from [<c01ce9a0>]
> > (__alloc_pages_nodemask)
> > [   27.216296] [<c01ce9a0>] (__alloc_pages_nodemask) from [<c01cf00c>]
> > (__get_free_pages+0x20/)
> > [   27.252326] [<c01cf00c>] (__get_free_pages) from [<c01e5bec>]
> > (kmalloc_order_trace+0x34/0xa)
> > [   27.288295] [<c01e5bec>] (kmalloc_order_trace) from [<c0203304>]
> > (__kmalloc+0x40/0x1ac)
> > [   27.323751] [<c0203304>] (__kmalloc) from [<c052abc0>]
> > (dwc2_hsotg_ep_queue.isra.12+0x7c/0x1)
> > [   27.359937] [<c052abc0>] (dwc2_hsotg_ep_queue.isra.12) from
> > [<c052af88>] (dwc2_hsotg_ep_queue)
> > [   27.397478] [<c052af88>] (dwc2_hsotg_ep_queue_lock) from
> > [<c0554110>] (rx_submit+0xfc/0x164)
> > [   27.433619] [<c0554110>] (rx_submit) from [<c05546e8>]
> > (rx_complete+0x22c/0x230)
> > [   27.468872] [<c05546e8>] (rx_complete) from [<c052b528>]
> > (dwc2_hsotg_complete_request+0xfc/0)
> > [   27.506240] [<c052b528>] (dwc2_hsotg_complete_request) from
> > [<c052bba0>] (dwc2_hsotg_handle_o)
> > [   27.545401] [<c052bba0>] (dwc2_hsotg_handle_outdone) from
> > [<c052be70>] (dwc2_hsotg_epint+0x2c)
> > [   27.583689] [<c052be70>] (dwc2_hsotg_epint) from [<c052c750>]
> > (dwc2_hsotg_irq+0x1dc/0x4ac)
> > [   27.621041] [<c052c750>] (dwc2_hsotg_irq) from [<c01682e0>]
> > (handle_irq_event_percpu+0x70/0x)
> > [   27.659066] [<c01682e0>] (handle_irq_event_percpu) from
> > [<c01684ec>] (handle_irq_event+0x4c)
> > [   27.697322] [<c01684ec>] (handle_irq_event) from [<c016bae0>]
> > (handle_fasteoi_irq+0xc8/0x11)
> > [   27.735451] [<c016bae0>] (handle_fasteoi_irq) from [<c0167b8c>]
> > (generic_handle_irq+0x30/0x)
> > [   27.773918] [<c0167b8c>] (generic_handle_irq) from [<c0167ca4>]
> > (__handle_domain_irq+0x84/0)
> > [   27.812018] [<c0167ca4>] (__handle_domain_irq) from [<c01003b0>]
> > (gic_handle_irq+0x48/0x6c)
> > [   27.849695] [<c01003b0>] (gic_handle_irq) from [<c010b340>]
> > (__irq_svc+0x40/0x50)
> > [   27.886907] Exception stack(0xc0d01ee0 to 0xc0d01f28)
> > 
> > Acked-by: John Youn <johnyoun@synopsys.com>
> > Tested-by: Heiko Stuebner <heiko@sntech.de>
> > Tested-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> > Signed-off-by: Yunzhi Li <lyz@rock-chips.com>
> 
> Hi Felipe,
> This patch has been hanging around for a while now. Can you please apply this?

https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=1c2e3377a933af9102f6c57c414c378a52d4e70d

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH v1 Resend] usb: dwc2: gadget: fix a memory use-after-free bug
  2015-10-01 17:21     ` Felipe Balbi
@ 2015-10-02  7:09       ` Kaukab, Yousaf
  0 siblings, 0 replies; 4+ messages in thread
From: Kaukab, Yousaf @ 2015-10-02  7:09 UTC (permalink / raw)
  To: balbi
  Cc: linux-usb, john.youn, lyz, heiko, cf, hl, yk, gauravsh, alberto,
	wulf, jwerner, jeffy.chen, Herrero, Gregory, huangtao,
	rockchip-discuss, gregkh, linux-kernel

> -----Original Message-----
> From: Felipe Balbi [mailto:balbi@ti.com]
> Sent: Thursday, October 1, 2015 7:21 PM
> To: Kaukab, Yousaf
> Cc: balbi@ti.com; linux-usb@vger.kernel.org; john.youn@synopsys.com;
> lyz@rock-chips.com; heiko@sntech.de; cf@rock-chips.com; hl@rock-chips.com;
> yk@rock-chips.com; gauravsh@google.com; alberto@google.com; wulf@rock-
> chips.com; jwerner@chromium.org; jeffy.chen@rock-chips.com; Herrero,
> Gregory; huangtao@rock-chips.com; rockchip-discuss@chromium.org;
> gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1 Resend] usb: dwc2: gadget: fix a memory use-after-free
> bug
> 
> On Thu, Oct 01, 2015 at 12:01:48PM +0000, Kaukab, Yousaf wrote:
> > > From: Mian Yousaf Kaukab <yousaf.kaukab@intel.com>
> > > Date: Tue, Sep 29, 2015 at 12:25 PM
> > > Subject: [PATCH v1 Resend] usb: dwc2: gadget: fix a memory
> > > use-after-free bug
> > > To: linux-usb@vger.kernel.org, balbi@ti.com, john.youn@synopsys.com,
> > > lyz@rock-chips.com
> > > Cc: heiko@sntech.de, cf@rock-chips.com, hl@rock-chips.com, yk@rock-
> > > chips.com, gauravsh@google.com, alberto@google.com,
> > > wulf@rock-chips.com, jwerner@chromium.org,
> > > jeffy.chen@rock-chips.com, gregory.herrero@intel.com,
> > > huangtao@rock-chips.com, rockchip- discuss@chromium.org,
> > > gregkh@linuxfoundation.org, linux- kernel@vger.kernel.org
> > >
> > >
> > > From: Yunzhi Li <lyz@rock-chips.com>
> > >
> > > When dwc2_hsotg_handle_unaligned_buf_complete() hs_req->req.buf
> > > already destroyed, in dwc2_hsotg_unmap_dma(), it touches
> > > hs_req->req.dma again, so
> > > dwc2_hsotg_unmap_dma() should be called before
> > > dwc2_hsotg_handle_unaligned_buf_complete(). Otherwise, it will cause
> > > a bad_page BUG, when allocate this memory page next time.
> > >
> > > This bug led to the following crash:
> > >
> > > BUG: Bad page state in process swapper/0  pfn:2bdbc
> > > [   26.820440] page:eed76780 count:0 mapcount:0 mapping:  (null)
> index:0x0
> > > [   26.854710] page flags: 0x200(arch_1)
> > > [   26.885836] page dumped because: PAGE_FLAGS_CHECK_AT_PREP flag
> set
> > > [   26.919179] bad because of flags:
> > > [   26.948917] page flags: 0x200(arch_1)
> > > [   26.979100] Modules linked in:
> > > [   27.008401] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W3.14.0 #17
> > > [   27.041816] [<c010e1f8>] (unwind_backtrace) from [<c010a704>]
> > > (show_stack+0x20/0x24)
> > > [   27.076108] [<c010a704>] (show_stack) from [<c087eea8>]
> > > (dump_stack+0x70/0x8c)
> > > [   27.110246] [<c087eea8>] (dump_stack) from [<c01ce0b8>]
> > > (bad_page+0xfc/0x12c)
> > > [   27.143958] [<c01ce0b8>] (bad_page) from [<c01ce65c>]
> > > (get_page_from_freelist+0x3e4/0x50c)
> > > [   27.179298] [<c01ce65c>] (get_page_from_freelist) from [<c01ce9a0>]
> > > (__alloc_pages_nodemask)
> > > [   27.216296] [<c01ce9a0>] (__alloc_pages_nodemask) from [<c01cf00c>]
> > > (__get_free_pages+0x20/)
> > > [   27.252326] [<c01cf00c>] (__get_free_pages) from [<c01e5bec>]
> > > (kmalloc_order_trace+0x34/0xa)
> > > [   27.288295] [<c01e5bec>] (kmalloc_order_trace) from [<c0203304>]
> > > (__kmalloc+0x40/0x1ac)
> > > [   27.323751] [<c0203304>] (__kmalloc) from [<c052abc0>]
> > > (dwc2_hsotg_ep_queue.isra.12+0x7c/0x1)
> > > [   27.359937] [<c052abc0>] (dwc2_hsotg_ep_queue.isra.12) from
> > > [<c052af88>] (dwc2_hsotg_ep_queue)
> > > [   27.397478] [<c052af88>] (dwc2_hsotg_ep_queue_lock) from
> > > [<c0554110>] (rx_submit+0xfc/0x164)
> > > [   27.433619] [<c0554110>] (rx_submit) from [<c05546e8>]
> > > (rx_complete+0x22c/0x230)
> > > [   27.468872] [<c05546e8>] (rx_complete) from [<c052b528>]
> > > (dwc2_hsotg_complete_request+0xfc/0)
> > > [   27.506240] [<c052b528>] (dwc2_hsotg_complete_request) from
> > > [<c052bba0>] (dwc2_hsotg_handle_o)
> > > [   27.545401] [<c052bba0>] (dwc2_hsotg_handle_outdone) from
> > > [<c052be70>] (dwc2_hsotg_epint+0x2c)
> > > [   27.583689] [<c052be70>] (dwc2_hsotg_epint) from [<c052c750>]
> > > (dwc2_hsotg_irq+0x1dc/0x4ac)
> > > [   27.621041] [<c052c750>] (dwc2_hsotg_irq) from [<c01682e0>]
> > > (handle_irq_event_percpu+0x70/0x)
> > > [   27.659066] [<c01682e0>] (handle_irq_event_percpu) from
> > > [<c01684ec>] (handle_irq_event+0x4c)
> > > [   27.697322] [<c01684ec>] (handle_irq_event) from [<c016bae0>]
> > > (handle_fasteoi_irq+0xc8/0x11)
> > > [   27.735451] [<c016bae0>] (handle_fasteoi_irq) from [<c0167b8c>]
> > > (generic_handle_irq+0x30/0x)
> > > [   27.773918] [<c0167b8c>] (generic_handle_irq) from [<c0167ca4>]
> > > (__handle_domain_irq+0x84/0)
> > > [   27.812018] [<c0167ca4>] (__handle_domain_irq) from [<c01003b0>]
> > > (gic_handle_irq+0x48/0x6c)
> > > [   27.849695] [<c01003b0>] (gic_handle_irq) from [<c010b340>]
> > > (__irq_svc+0x40/0x50)
> > > [   27.886907] Exception stack(0xc0d01ee0 to 0xc0d01f28)
> > >
> > > Acked-by: John Youn <johnyoun@synopsys.com>
> > > Tested-by: Heiko Stuebner <heiko@sntech.de>
> > > Tested-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> > > Signed-off-by: Yunzhi Li <lyz@rock-chips.com>
> >
> > Hi Felipe,
> > This patch has been hanging around for a while now. Can you please apply
> this?
> 
> https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/nex
> t&id=1c2e3377a933af9102f6c57c414c378a52d4e70d

Thanks!

> 
> --
> balbi

BR,
Yousaf

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-02  7:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-29 10:25 [PATCH v1 Resend] usb: dwc2: gadget: fix a memory use-after-free bug Mian Yousaf Kaukab
     [not found] ` <CAOZ-Yot=qFZKrcCcPAsKdpDMT58_kPJ68sPaSKngF8dG+5ZDSg@mail.gmail.com>
2015-10-01 12:01   ` Kaukab, Yousaf
2015-10-01 17:21     ` Felipe Balbi
2015-10-02  7:09       ` Kaukab, Yousaf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®