mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [GIT PULL] phy: for 4.3 -rc
@ 2015-09-29  6:35 Kishon Vijay Abraham I
  2015-09-29  6:35 ` [PATCH 1/3] phy: qcom-ufs: fix build error when the component is built as a module Kishon Vijay Abraham I
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Kishon Vijay Abraham I @ 2015-09-29  6:35 UTC (permalink / raw)
  To: gregkh; +Cc: kishon, linux-kernel

Hi Greg,

Please find the pull request for 4.3 -rc cycle below. This includes
misc fixes in three of the PHY drivers. Please see the tag message for
the details.

Let me know if I have to change something.

Cheers
Kishon

The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:

  Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git tags/phy-for-4.3-rc

for you to fetch changes up to f9fef6181a9590261c296be9e2a19b6aa3c13ba7:

  phy: berlin-sata: Fix module autoload for OF platform driver (2015-09-25 17:01:14 +0530)

----------------------------------------------------------------
phy: for 4.3-rc

*) Fix compiler error in qcom-ufs when it is built as module
*) Power down rockchip-usb PHY during probe to save power consumption
*) Fix module autoload for berlin-sata PHY driver

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

----------------------------------------------------------------
Luis de Bethencourt (1):
      phy: berlin-sata: Fix module autoload for OF platform driver

Yaniv Gardi (1):
      phy: qcom-ufs: fix build error when the component is built as a module

huang lin (1):
      phy: rockchip-usb: power down phy when rockchip phy probe

 drivers/phy/phy-berlin-sata.c  |    1 +
 drivers/phy/phy-qcom-ufs.c     |   11 +++++++++++
 drivers/phy/phy-rockchip-usb.c |    6 ++++++
 3 files changed, 18 insertions(+)

-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] phy: qcom-ufs: fix build error when the component is built as a module
  2015-09-29  6:35 [GIT PULL] phy: for 4.3 -rc Kishon Vijay Abraham I
@ 2015-09-29  6:35 ` Kishon Vijay Abraham I
  2015-09-29  6:35 ` [PATCH 2/3] phy: rockchip-usb: power down phy when rockchip phy probe Kishon Vijay Abraham I
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Kishon Vijay Abraham I @ 2015-09-29  6:35 UTC (permalink / raw)
  To: gregkh; +Cc: kishon, linux-kernel

From: Yaniv Gardi <ygardi@codeaurora.org>

Export the following functions in order to avoid build errors
when the component PHY_QCOM_UFS is compiled as a module:

ERROR: "ufs_qcom_phy_disable_ref_clk"
	[drivers/scsi/ufs/ufs-qcom.ko] undefined!
ERROR: "ufs_qcom_phy_enable_ref_clk"
	[drivers/scsi/ufs/ufs-qcom.ko] undefined!
ERROR: "ufs_qcom_phy_is_pcs_ready"
	[drivers/scsi/ufs/ufs-qcom.ko] undefined!
ERROR: "ufs_qcom_phy_disable_iface_clk"
	[drivers/scsi/ufs/ufs-qcom.ko] undefined!
ERROR: "ufs_qcom_phy_start_serdes"
	[drivers/scsi/ufs/ufs-qcom.ko] undefined!
ERROR: "ufs_qcom_phy_calibrate_phy"
	[drivers/scsi/ufs/ufs-qcom.ko] undefined!
ERROR: "ufs_qcom_phy_enable_dev_ref_clk"
	[drivers/scsi/ufs/ufs-qcom.ko] undefined!
ERROR: "ufs_qcom_phy_set_tx_lane_enable"
	[drivers/scsi/ufs/ufs-qcom.ko] undefined!
ERROR: "ufs_qcom_phy_disable_dev_ref_clk"
	[drivers/scsi/ufs/ufs-qcom.ko] undefined!
ERROR: "ufs_qcom_phy_save_controller_version"
	[drivers/scsi/ufs/ufs-qcom.ko] undefined!
ERROR: "ufs_qcom_phy_enable_iface_clk"
	[drivers/scsi/ufs/ufs-qcom.ko] undefined!
make[1]: *** [__modpost] Error 1

Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/phy/phy-qcom-ufs.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
index 49a1ed0..107cb57 100644
--- a/drivers/phy/phy-qcom-ufs.c
+++ b/drivers/phy/phy-qcom-ufs.c
@@ -432,6 +432,7 @@ out_disable_src:
 out:
 	return ret;
 }
+EXPORT_SYMBOL_GPL(ufs_qcom_phy_enable_ref_clk);
 
 static
 int ufs_qcom_phy_disable_vreg(struct phy *phy,
@@ -474,6 +475,7 @@ void ufs_qcom_phy_disable_ref_clk(struct phy *generic_phy)
 		phy->is_ref_clk_enabled = false;
 	}
 }
+EXPORT_SYMBOL_GPL(ufs_qcom_phy_disable_ref_clk);
 
 #define UFS_REF_CLK_EN	(1 << 5)
 
@@ -517,11 +519,13 @@ void ufs_qcom_phy_enable_dev_ref_clk(struct phy *generic_phy)
 {
 	ufs_qcom_phy_dev_ref_clk_ctrl(generic_phy, true);
 }
+EXPORT_SYMBOL_GPL(ufs_qcom_phy_enable_dev_ref_clk);
 
 void ufs_qcom_phy_disable_dev_ref_clk(struct phy *generic_phy)
 {
 	ufs_qcom_phy_dev_ref_clk_ctrl(generic_phy, false);
 }
+EXPORT_SYMBOL_GPL(ufs_qcom_phy_disable_dev_ref_clk);
 
 /* Turn ON M-PHY RMMI interface clocks */
 int ufs_qcom_phy_enable_iface_clk(struct phy *generic_phy)
@@ -550,6 +554,7 @@ int ufs_qcom_phy_enable_iface_clk(struct phy *generic_phy)
 out:
 	return ret;
 }
+EXPORT_SYMBOL_GPL(ufs_qcom_phy_enable_iface_clk);
 
 /* Turn OFF M-PHY RMMI interface clocks */
 void ufs_qcom_phy_disable_iface_clk(struct phy *generic_phy)
@@ -562,6 +567,7 @@ void ufs_qcom_phy_disable_iface_clk(struct phy *generic_phy)
 		phy->is_iface_clk_enabled = false;
 	}
 }
+EXPORT_SYMBOL_GPL(ufs_qcom_phy_disable_iface_clk);
 
 int ufs_qcom_phy_start_serdes(struct phy *generic_phy)
 {
@@ -578,6 +584,7 @@ int ufs_qcom_phy_start_serdes(struct phy *generic_phy)
 
 	return ret;
 }
+EXPORT_SYMBOL_GPL(ufs_qcom_phy_start_serdes);
 
 int ufs_qcom_phy_set_tx_lane_enable(struct phy *generic_phy, u32 tx_lanes)
 {
@@ -595,6 +602,7 @@ int ufs_qcom_phy_set_tx_lane_enable(struct phy *generic_phy, u32 tx_lanes)
 
 	return ret;
 }
+EXPORT_SYMBOL_GPL(ufs_qcom_phy_set_tx_lane_enable);
 
 void ufs_qcom_phy_save_controller_version(struct phy *generic_phy,
 					  u8 major, u16 minor, u16 step)
@@ -605,6 +613,7 @@ void ufs_qcom_phy_save_controller_version(struct phy *generic_phy,
 	ufs_qcom_phy->host_ctrl_rev_minor = minor;
 	ufs_qcom_phy->host_ctrl_rev_step = step;
 }
+EXPORT_SYMBOL_GPL(ufs_qcom_phy_save_controller_version);
 
 int ufs_qcom_phy_calibrate_phy(struct phy *generic_phy, bool is_rate_B)
 {
@@ -625,6 +634,7 @@ int ufs_qcom_phy_calibrate_phy(struct phy *generic_phy, bool is_rate_B)
 
 	return ret;
 }
+EXPORT_SYMBOL_GPL(ufs_qcom_phy_calibrate_phy);
 
 int ufs_qcom_phy_remove(struct phy *generic_phy,
 			struct ufs_qcom_phy *ufs_qcom_phy)
@@ -662,6 +672,7 @@ int ufs_qcom_phy_is_pcs_ready(struct phy *generic_phy)
 	return ufs_qcom_phy->phy_spec_ops->
 			is_physical_coding_sublayer_ready(ufs_qcom_phy);
 }
+EXPORT_SYMBOL_GPL(ufs_qcom_phy_is_pcs_ready);
 
 int ufs_qcom_phy_power_on(struct phy *generic_phy)
 {
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/3] phy: rockchip-usb: power down phy when rockchip phy probe
  2015-09-29  6:35 [GIT PULL] phy: for 4.3 -rc Kishon Vijay Abraham I
  2015-09-29  6:35 ` [PATCH 1/3] phy: qcom-ufs: fix build error when the component is built as a module Kishon Vijay Abraham I
@ 2015-09-29  6:35 ` Kishon Vijay Abraham I
  2015-09-29  6:35 ` [PATCH 3/3] phy: berlin-sata: Fix module autoload for OF platform driver Kishon Vijay Abraham I
  2015-10-03 11:41 ` [GIT PULL] phy: for 4.3 -rc Greg KH
  3 siblings, 0 replies; 5+ messages in thread
From: Kishon Vijay Abraham I @ 2015-09-29  6:35 UTC (permalink / raw)
  To: gregkh; +Cc: kishon, linux-kernel

From: huang lin <hl@rock-chips.com>

rockchip phy are enable when soc reset, to save power consumption,
we disable it when probe, and enable each phy when it use

Signed-off-by: huang lin <hl@rock-chips.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/phy/phy-rockchip-usb.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/phy/phy-rockchip-usb.c b/drivers/phy/phy-rockchip-usb.c
index 5a5c073..91d6f34 100644
--- a/drivers/phy/phy-rockchip-usb.c
+++ b/drivers/phy/phy-rockchip-usb.c
@@ -98,6 +98,7 @@ static int rockchip_usb_phy_probe(struct platform_device *pdev)
 	struct device_node *child;
 	struct regmap *grf;
 	unsigned int reg_offset;
+	int err;
 
 	grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,grf");
 	if (IS_ERR(grf)) {
@@ -129,6 +130,11 @@ static int rockchip_usb_phy_probe(struct platform_device *pdev)
 			return PTR_ERR(rk_phy->phy);
 		}
 		phy_set_drvdata(rk_phy->phy, rk_phy);
+
+		/* only power up usb phy when it use, so disable it when init*/
+		err = rockchip_usb_phy_power(rk_phy, 1);
+		if (err)
+			return err;
 	}
 
 	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 3/3] phy: berlin-sata: Fix module autoload for OF platform driver
  2015-09-29  6:35 [GIT PULL] phy: for 4.3 -rc Kishon Vijay Abraham I
  2015-09-29  6:35 ` [PATCH 1/3] phy: qcom-ufs: fix build error when the component is built as a module Kishon Vijay Abraham I
  2015-09-29  6:35 ` [PATCH 2/3] phy: rockchip-usb: power down phy when rockchip phy probe Kishon Vijay Abraham I
@ 2015-09-29  6:35 ` Kishon Vijay Abraham I
  2015-10-03 11:41 ` [GIT PULL] phy: for 4.3 -rc Greg KH
  3 siblings, 0 replies; 5+ messages in thread
From: Kishon Vijay Abraham I @ 2015-09-29  6:35 UTC (permalink / raw)
  To: gregkh; +Cc: kishon, linux-kernel

From: Luis de Bethencourt <luis@debethencourt.com>

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/phy/phy-berlin-sata.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/phy-berlin-sata.c b/drivers/phy/phy-berlin-sata.c
index 0062027..77a2e05 100644
--- a/drivers/phy/phy-berlin-sata.c
+++ b/drivers/phy/phy-berlin-sata.c
@@ -276,6 +276,7 @@ static const struct of_device_id phy_berlin_sata_of_match[] = {
 	{ .compatible = "marvell,berlin2q-sata-phy" },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match);
 
 static struct platform_driver phy_berlin_sata_driver = {
 	.probe	= phy_berlin_sata_probe,
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL] phy: for 4.3 -rc
  2015-09-29  6:35 [GIT PULL] phy: for 4.3 -rc Kishon Vijay Abraham I
                   ` (2 preceding siblings ...)
  2015-09-29  6:35 ` [PATCH 3/3] phy: berlin-sata: Fix module autoload for OF platform driver Kishon Vijay Abraham I
@ 2015-10-03 11:41 ` Greg KH
  3 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2015-10-03 11:41 UTC (permalink / raw)
  To: Kishon Vijay Abraham I; +Cc: linux-kernel

On Tue, Sep 29, 2015 at 12:05:21PM +0530, Kishon Vijay Abraham I wrote:
> Hi Greg,
> 
> Please find the pull request for 4.3 -rc cycle below. This includes
> misc fixes in three of the PHY drivers. Please see the tag message for
> the details.
> 
> Let me know if I have to change something.
> 
> Cheers
> Kishon
> 
> The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:
> 
>   Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git tags/phy-for-4.3-rc

Pulled into my tree now, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-10-03 11:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-29  6:35 [GIT PULL] phy: for 4.3 -rc Kishon Vijay Abraham I
2015-09-29  6:35 ` [PATCH 1/3] phy: qcom-ufs: fix build error when the component is built as a module Kishon Vijay Abraham I
2015-09-29  6:35 ` [PATCH 2/3] phy: rockchip-usb: power down phy when rockchip phy probe Kishon Vijay Abraham I
2015-09-29  6:35 ` [PATCH 3/3] phy: berlin-sata: Fix module autoload for OF platform driver Kishon Vijay Abraham I
2015-10-03 11:41 ` [GIT PULL] phy: for 4.3 -rc Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®