From: Greg KH <gregkh@linuxfoundation.org>
To: Mike Dupuis <mike.dupuis.0@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null()
Date: Sun, 4 Oct 2015 20:43:13 +0100 [thread overview]
Message-ID: <20151004194313.GB23542@kroah.com> (raw)
In-Reply-To: <CABTjXUT5E3oK1e8OxqTDc+1wmoHxMFV4SM8RmJE_FhtEmg48cw@mail.gmail.com>
On Sun, Oct 04, 2015 at 10:46:05AM -0800, Mike Dupuis wrote:
> > And I think you just broke the "autoload" logic that these "call a null
> > function" function calls were trying to solve, which isn't good at all.
>
> I guess this bit is lost on me-- how does calling a function from a
> previously unused object affect the state of a driver or kernel module?
It forces the module where that function is to be loaded into memory
before this function can be called.
That is if we have multiple modules here, I haven't looked at the code
in a long time to verify it, but note, you are totally ignoring the
comment put there in the code that says this.
greg k-h
prev parent reply other threads:[~2015-10-04 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 21:09 mike dupuis
2015-10-04 8:49 ` Greg KH
[not found] ` <CABTjXUT5E3oK1e8OxqTDc+1wmoHxMFV4SM8RmJE_FhtEmg48cw@mail.gmail.com>
2015-10-04 19:43 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151004194313.GB23542@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.dupuis.0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®