From: Mark Brown <broonie@kernel.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH 1/2] ASoC: da7213: Add DT support to codec driver
Date: Mon, 5 Oct 2015 16:55:43 +0100 [thread overview]
Message-ID: <20151005155543.GY12635@sirena.org.uk> (raw)
In-Reply-To: <8b10191f4e14b32f831d32c66c7edebd861b70ac.1444042230.git.Adam.Thomson.Opensource@diasemi.com>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On Mon, Oct 05, 2015 at 04:40:18PM +0100, Adam Thomson wrote:
> This patch adds support for DT bindings in the codec driver.
> As part of this support, the mclk data can now be provided and
> used to control the mclk during codec operation.
Please split out the new MCLK configuration into a separate patch which
describes what that configuration is, it's much easier to review that
way. Otherwise there's a couple of minor issues here but nothing too
critical.
> case SND_SOC_BIAS_STANDBY:
> if (snd_soc_codec_get_bias_level(codec) == SND_SOC_BIAS_OFF) {
> + /* MCLK */
> + clk_prepare_enable(da7213->mclk);
> +
This doesn't check the return value.
> .driver = {
> .name = "da7213",
> + .of_match_table = da7213_of_match,
Please use of_match_ptr() here.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-05 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 15:40 [PATCH 0/2] ASoC: da7213: Add DT support for codec Adam Thomson
2015-10-05 15:40 ` [PATCH 1/2] ASoC: da7213: Add DT support to codec driver Adam Thomson
2015-10-05 15:55 ` Mark Brown [this message]
2015-10-05 22:24 ` Opensource [Adam Thomson]
2015-10-05 15:40 ` [PATCH 2/2] ASoC: da7213: Add bindings documentation for " Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005155543.GY12635@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®