From: Francois Romieu <romieu@fr.zoreil.com>
To: Andrej Ota <andrej@ota.si>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] via-rhine: fix VLAN receive handling error in 4.2.x
Date: Tue, 6 Oct 2015 09:34:47 +0200 [thread overview]
Message-ID: <20151006073447.GA10346@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20151004200603.380C4F4DA@mta2.toshio.eu>
Andrej Ota <andrej@ota.si> :
> Fixes commit 810f19bcb862 ("via-rhine: add consistent memory barrier in
> vlan receive code.") which broke VLAN tag parsing on receive.
>
> Because eth_type_trans() consumes ethernet header worth of bytes, a call
> to read TCI from packet using rhine_rx_vlan_tag() no longer works as it's
> reading from an invalid offset.
>
> Tested to be working on PCEngines Alix board.
>
> Fixes: 810f19bcb862 ("via-rhine: add consistent memory barrier in vlan receive code.")
> Signed-off-by: Andrej Ota <andrej@ota.si>
Minor nits:
- Ethernet driver patches should usually be sent to netdev@vger.kernel.org.
Their state is thus tracked at
http://patchwork.ozlabs.org/project/netdev/list/
- The more specific about the target branch, the better:
[PATCH net 1/1] via-rhine: blah
-> patch against davem's bugfixes branch
[PATCH net-next 19/73] foo: more balh
-> patch against davem's dev branch
- davem will take care of -stable propagation
--
Ueimor
prev parent reply other threads:[~2015-10-06 7:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 17:21 Andrej
2015-10-03 21:47 ` Francois Romieu
2015-10-04 20:05 ` [PATCH] " Andrej Ota
2015-10-06 7:34 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006073447.GA10346@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=andrej@ota.si \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®