From: Mark Brown <broonie@kernel.org>
To: Jiada Wang <jiada_wang@mentor.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume
Date: Tue, 6 Oct 2015 11:59:07 +0100 [thread overview]
Message-ID: <20151006105907.GM12635@sirena.org.uk> (raw)
In-Reply-To: <1444115215-4388-2-git-send-email-jiada_wang@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
On Tue, Oct 06, 2015 at 04:06:54PM +0900, Jiada Wang wrote:
> + /* All registers have been reset to default value without calling
> + * to regmap interface, even if reset fails, some registers
> + * maybe in intermediate status, so we need to mark regmap
> + * cache_dirty flag.
> + */
> + regcache_mark_dirty(wm8962->regmap);
This is a standard thing that applies to almost all devices, there
should be no need for such an extensive comment (which would normally
flag up that there's something weird and surprising going on).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-06 11:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 7:06 [PATCH 0/2] *** wm8962 regmap related fix *** Jiada Wang
2015-10-06 7:06 ` [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume Jiada Wang
2015-10-06 10:59 ` Mark Brown [this message]
2015-10-08 1:34 ` Jiada Wang
2015-10-06 7:06 ` [PATCH 2/2] ASoC: Codec: wm8962: declare ALC Coefficients as 4 separate registers Jiada Wang
2015-10-06 11:01 ` Mark Brown
2015-10-08 3:11 ` Jiada Wang
2015-10-20 2:47 [PATCH v2 0/2] *** wm8962 regmap related fix *** Jiada Wang
2015-10-20 2:47 ` [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume Jiada Wang
2015-10-20 7:55 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006105907.GM12635@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jiada_wang@mentor.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®