mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Jeff Layton <jlayton@poochiereds.net>,
	linux-fsdevel@vger.kernel.org, Miklos Szeredi <mszeredi@suse.cz>,
	David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] vfs: remove stale comment in inode_operations
Date: Thu, 8 Oct 2015 17:07:20 -0600	[thread overview]
Message-ID: <20151008230720.GA19399@linux.intel.com> (raw)
In-Reply-To: <1441753160-26476-1-git-send-email-ross.zwisler@linux.intel.com>

On Tue, Sep 08, 2015 at 04:59:20PM -0600, Ross Zwisler wrote:
> The big warning comment that is currently at the end of struct
> inode_operations was added as part of this commit:
> 
> 4aa7c6346be3 ("vfs: add i_op->dentry_open()")
> 
> It was added to warn people not to use the newly added 'dentry_open'
> function pointer.
> 
> This function pointer was removed as part of this commit:
> 
> 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and
> 		f_inode to the underlay")
> 
> The comment was left behind and now refers to nothing, so remove it.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
>  include/linux/fs.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index b2f9b9c..b3ff479 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -1679,8 +1679,6 @@ struct inode_operations {
>  			   umode_t create_mode, int *opened);
>  	int (*tmpfile) (struct inode *, struct dentry *, umode_t);
>  	int (*set_acl)(struct inode *, struct posix_acl *, int);
> -
> -	/* WARNING: probably going away soon, do not use! */
>  } ____cacheline_aligned;
>  
>  ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector,

Ping?

  reply	other threads:[~2015-10-08 23:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-08 22:59 Ross Zwisler
2015-10-08 23:07 ` Ross Zwisler [this message]
2015-10-12 13:44   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151008230720.GA19399@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=bfields@fieldses.org \
    --cc=dhowells@redhat.com \
    --cc=jlayton@poochiereds.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mszeredi@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome