From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] locktorture: fix wrong parameter handling
Date: Fri, 9 Oct 2015 08:44:20 -0700 [thread overview]
Message-ID: <20151009154420.GT3910@linux.vnet.ibm.com> (raw)
In-Reply-To: <5617D4FD.3030803@de.ibm.com>
On Fri, Oct 09, 2015 at 04:53:49PM +0200, Christian Borntraeger wrote:
> Am 09.10.2015 um 16:46 schrieb Paul E. McKenney:
> > On Fri, Oct 09, 2015 at 02:14:45PM +0200, Christian Borntraeger wrote:
> >> Calling locktorture with a wrong parameter makes it
> >> unusable:
> >>
> >> $ modprobe locktorture torture_type=help
> >> modprobe: ERROR: could not insert 'locktorture': Invalid argument
> >>
> >> $ modprobe locktorture torture_type=spin_lock
> >> modprobe: ERROR: could not insert 'locktorture': Device or resource busy
> >>
> >> $ dmesg
> >> [...]
> >> torture_init_begin: refusing spin_lock init: help running
> >>
> >> We can easily do the checking before call into the torture framework.
> >>
> >> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> >
> > Good catch, thank you!
> >
> > Could you please port this to rcu/next in the -rcu tree? Also, please
> > capitalize the word following the ":" in the subject line, as in "[PATCH]
> > locktorture: Fix wrong parameter handling".
>
> Hmmm, seems that this is already fixed in rcu/next with
>
> commit a36a99618b1adb2d6ca0b7e08e3a656a04e477fe
> Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> AuthorDate: Sun Aug 30 20:01:48 2015 -0700
> Commit: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> CommitDate: Tue Oct 6 11:28:44 2015 -0700
>
> locktorture: Fix module unwind when bad torture_type specified
>
>
> No need to respin a patch it seems :-)
Works for me! ;-)
Thanx, Paul
prev parent reply other threads:[~2015-10-09 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 12:14 Christian Borntraeger
2015-10-09 14:46 ` Paul E. McKenney
2015-10-09 14:53 ` Christian Borntraeger
2015-10-09 15:44 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009154420.GT3910@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome