From: Vinod Koul <vinod.koul@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: zxdma: fix memset that is currently doing nothing
Date: Fri, 9 Oct 2015 16:50:39 +0100 [thread overview]
Message-ID: <20151009155038.GF3609@vkoul-mobl.iind.intel.com> (raw)
In-Reply-To: <1444323694-3189-1-git-send-email-colin.king@canonical.com>
On Thu, Oct 08, 2015 at 06:01:34PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The size and value arguments are swapped in the call to memset
> effectively making it a no-op because of the zero size. Swap
> these arguments around to do the memset correctly.
Sorry you are late! You should always sync to target tree before generating
a patch
commit 1a492ac2b87b05c8a175478e79d3c74511c74921
Author: Vinod Koul <vinod.koul@intel.com>
Date: Thu Oct 1 07:11:48 2015 +0530
dmaengine: zxdma: fix memset call
Fix the call to memset in this driver
[linux-4.2-next-20150911/drivers/dma/zx296702_dma.c:444]: (warning)
memset() called to fill 0 bytes of 'ds'.
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
prev parent reply other threads:[~2015-10-09 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 17:01 Colin King
2015-10-09 15:50 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009155038.GF3609@vkoul-mobl.iind.intel.com \
--to=vinod.koul@intel.com \
--cc=colin.king@canonical.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®