From: Mark Brown <broonie@kernel.org>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: yalin wang <yalin.wang2010@gmail.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap
Date: Mon, 12 Oct 2015 17:26:58 +0100 [thread overview]
Message-ID: <20151012162658.GH4238@sirena.org.uk> (raw)
In-Reply-To: <20151012104858.GA6786@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
On Mon, Oct 12, 2015 at 12:48:58PM +0200, Markus Pargmann wrote:
> On Fri, Oct 09, 2015 at 03:51:22PM +0800, yalin wang wrote:
> > + /* if set, only the cache is modified not the HW */
> > + bool cache_only;
> > + /* if set, only the HW is modified not the cache */
> > + bool cache_bypass;
> > + /* if set, the cache contains newer data than the HW */
> > + bool cache_dirty;
> Why are these last three variables just moved and not changed to u8 of
> size 1?
They're exported to debugfs and the relevant debugfs helpers take bool
as an argument (actually I've got a feeling the relevant API is changed
in -next which is likely to be an issue here...).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-10-12 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 7:51 yalin wang
2015-10-09 11:35 ` Mark Brown
2015-10-10 1:24 ` yalin wang
2015-10-12 10:48 ` Markus Pargmann
2015-10-12 16:26 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012162658.GH4238@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=yalin.wang2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®