mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] soc: qcom: smd: Correct SMEM items for upper channels
@ 2015-10-10  4:35 Bjorn Andersson
  2015-10-10  5:06 ` [RESEND PATCH] " bjorn
  2015-10-12 16:36 ` [PATCH] " Andy Gross
  0 siblings, 2 replies; 4+ messages in thread
From: Bjorn Andersson @ 2015-10-10  4:35 UTC (permalink / raw)
  To: Andy Gross; +Cc: linux-arm-msm, linux-soc, linux-kernel

Update the SMEM items for the second set of SMD channels, as these where
incorrect.

Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---
 drivers/soc/qcom/smd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c
index 18964f1..e7fb8fa 100644
--- a/drivers/soc/qcom/smd.c
+++ b/drivers/soc/qcom/smd.c
@@ -87,8 +87,8 @@ static const struct {
 		.fifo_base_id = 338
 	},
 	{
-		.alloc_tbl_id = 14,
-		.info_base_id = 266,
+		.alloc_tbl_id = 266,
+		.info_base_id = 138,
 		.fifo_base_id = 202,
 	},
 };
-- 
2.3.2 (Apple Git-55)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [RESEND PATCH] soc: qcom: smd: Correct SMEM items for upper channels
  2015-10-10  4:35 [PATCH] soc: qcom: smd: Correct SMEM items for upper channels Bjorn Andersson
@ 2015-10-10  5:06 ` bjorn
  2015-10-12 16:36 ` [PATCH] " Andy Gross
  1 sibling, 0 replies; 4+ messages in thread
From: bjorn @ 2015-10-10  5:06 UTC (permalink / raw)
  To: Andy Gross; +Cc: linux-arm-msm, linux-soc, linux-kernel

From: Bjorn Andersson <bjorn.andersson@sonymobile.com>

Update the SMEM items for the second set of SMD channels, as these where
incorrect.

Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---

Corrected .gitconfig mishap which gave wrong author.

 drivers/soc/qcom/smd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c
index 18964f1..e7fb8fa 100644
--- a/drivers/soc/qcom/smd.c
+++ b/drivers/soc/qcom/smd.c
@@ -87,8 +87,8 @@ static const struct {
 		.fifo_base_id = 338
 	},
 	{
-		.alloc_tbl_id = 14,
-		.info_base_id = 266,
+		.alloc_tbl_id = 266,
+		.info_base_id = 138,
 		.fifo_base_id = 202,
 	},
 };
-- 
2.3.2 (Apple Git-55)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] soc: qcom: smd: Correct SMEM items for upper channels
  2015-10-10  4:35 [PATCH] soc: qcom: smd: Correct SMEM items for upper channels Bjorn Andersson
  2015-10-10  5:06 ` [RESEND PATCH] " bjorn
@ 2015-10-12 16:36 ` Andy Gross
  2015-10-12 17:19   ` Bjorn Andersson
  1 sibling, 1 reply; 4+ messages in thread
From: Andy Gross @ 2015-10-12 16:36 UTC (permalink / raw)
  To: Bjorn Andersson; +Cc: linux-arm-msm, linux-soc, linux-kernel

On Fri, Oct 09, 2015 at 09:35:37PM -0700, Bjorn Andersson wrote:
> Update the SMEM items for the second set of SMD channels, as these where
> incorrect.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>

Nice.  Good catch.  I verified by counting through the #defines in the
codeaurora code.

Reviewed-by: Andy Gross <agross@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] soc: qcom: smd: Correct SMEM items for upper channels
  2015-10-12 16:36 ` [PATCH] " Andy Gross
@ 2015-10-12 17:19   ` Bjorn Andersson
  0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2015-10-12 17:19 UTC (permalink / raw)
  To: Andy Gross; +Cc: linux-arm-msm, linux-soc, linux-kernel

On Mon, Oct 12, 2015 at 9:36 AM, Andy Gross <agross@codeaurora.org> wrote:
> On Fri, Oct 09, 2015 at 09:35:37PM -0700, Bjorn Andersson wrote:
>> Update the SMEM items for the second set of SMD channels, as these where
>> incorrect.
>>
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
>
> Nice.  Good catch.  I verified by counting through the #defines in the
> codeaurora code.
>

I grew tired of resolving that huge enum list, so I created this:
http://elinux.org/Qualcomm_SMEM_Items

Was planning to document the items as I go, but the list of numbers is
the most important part.

Regards,
Bjorn

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-10-12 17:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-10  4:35 [PATCH] soc: qcom: smd: Correct SMEM items for upper channels Bjorn Andersson
2015-10-10  5:06 ` [RESEND PATCH] " bjorn
2015-10-12 16:36 ` [PATCH] " Andy Gross
2015-10-12 17:19   ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®