mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: akpm@linux-foundation.org, yinghai@kernel.org, dyoung@redhat.com,
	jroedel@suse.de
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bp@suse.de,
	linux-kernel@vger.kernel.org, jerry_hoemann@hp.com
Subject: Re: [PATCH] Do not reserve crashkernel high memory if crashkernel low memory reserving failed
Date: Wed, 14 Oct 2015 14:16:37 +0800	[thread overview]
Message-ID: <20151014061637.GA32656@dhcp-128-28.nay.redhat.com> (raw)
In-Reply-To: <1443065091-28198-1-git-send-email-bhe@redhat.com>

Hi all,

Ping.

Any other suggestion for this fix?


On 09/24/15 at 11:24am, Baoquan He wrote:
> People reported that when allocating crashkernel memory using
> ",high" and ",low" syntax, there were cases where the reservation
> of the "high" portion succeeds, but the reservation of the "low"
> portion fails. Then kexec can load kdump kernel successfully, but
> the boot of kdump kernel fails as there's no low memory. This is
> because allocation of low memory for kdump kernel can fail on large
> systems for reasons. E.g it could be manually specified crashkernel
> low memory is too large to find in memblock region.
> 
> In this patch add return value for reserve_crashkernel_low. Then
> try to reserve crashkernel low memory after crashkernel high memory
> has been allocated. If crashkernel low memory reservation failed
> free crashkernel high memory and return. User can take measures
> when they found kdump kernel cann't be loaded successfully.
> 
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
> v1->v2:
>   Boris commented that error value EINVAL is negative, should
>   use "return -EINVAL".
> 
> v2->v3:
>   Yinghai pointed out that during memblock_reserve, we could double
>   the memblock reserve array. New memblock reserve could be overlapped
>   with range for crashkernel high. So we have to reserve crashkernel
>   high firstly, then free it if crashkernel low memory allocation
>   failed.
> 
> v3->v4:
>   Dave suggested using "return -ENOMEM" when low memory reservation
>   failed and printing failure message anyway.
> 
> v4->v5:
>   Andrew suggested changing the content of failure message and taking
>   higher severity KERN_ERR.
> 
>  arch/x86/kernel/setup.c | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index fdb7f2a..e510e61 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -493,7 +493,7 @@ static void __init memblock_x86_reserve_range_setup_data(void)
>  # define CRASH_KERNEL_ADDR_HIGH_MAX	MAXMEM
>  #endif
>  
> -static void __init reserve_crashkernel_low(void)
> +static int __init reserve_crashkernel_low(void)
>  {
>  #ifdef CONFIG_X86_64
>  	const unsigned long long alignment = 16<<20;	/* 16M */
> @@ -522,17 +522,16 @@ static void __init reserve_crashkernel_low(void)
>  	} else {
>  		/* passed with crashkernel=0,low ? */
>  		if (!low_size)
> -			return;
> +			return 0;
>  	}
>  
>  	low_base = memblock_find_in_range(low_size, (1ULL<<32),
>  					low_size, alignment);
>  
>  	if (!low_base) {
> -		if (!auto_set)
> -			pr_info("crashkernel low reservation failed - No suitable area found.\n");
> -
> -		return;
> +		pr_err("Failed to reserve %ldMB of low memory for crashkernel, please try smaller size.\n",
> +				(unsigned long)(low_size >> 20));
> +		return -ENOMEM;
>  	}
>  
>  	memblock_reserve(low_base, low_size);
> @@ -544,6 +543,7 @@ static void __init reserve_crashkernel_low(void)
>  	crashk_low_res.end   = low_base + low_size - 1;
>  	insert_resource(&iomem_resource, &crashk_low_res);
>  #endif
> +	return 0;
>  }
>  
>  static void __init reserve_crashkernel(void)
> @@ -595,6 +595,11 @@ static void __init reserve_crashkernel(void)
>  	}
>  	memblock_reserve(crash_base, crash_size);
>  
> +	if (crash_base >= (1ULL<<32) && reserve_crashkernel_low()) {
> +		memblock_free(crash_base, crash_size);
> +		return;
> +	}
> +
>  	printk(KERN_INFO "Reserving %ldMB of memory at %ldMB "
>  			"for crashkernel (System RAM: %ldMB)\n",
>  			(unsigned long)(crash_size >> 20),
> @@ -604,9 +609,6 @@ static void __init reserve_crashkernel(void)
>  	crashk_res.start = crash_base;
>  	crashk_res.end   = crash_base + crash_size - 1;
>  	insert_resource(&iomem_resource, &crashk_res);
> -
> -	if (crash_base >= (1ULL<<32))
> -		reserve_crashkernel_low();
>  }
>  #else
>  static void __init reserve_crashkernel(void)
> -- 
> 2.4.0
> 

  reply	other threads:[~2015-10-14  6:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24  3:24 Baoquan He
2015-10-14  6:16 ` Baoquan He [this message]
2015-10-14  8:43 ` Joerg Roedel
2015-10-14 10:43   ` Borislav Petkov
  -- strict thread matches above, loose matches on Subject: below --
2015-07-19 11:07 Baoquan He
2015-07-19 13:40 ` Borislav Petkov
2015-07-19 14:23   ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151014061637.GA32656@dhcp-128-28.nay.redhat.com \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@suse.de \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jerry_hoemann@hp.com \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®