From: Mark Brown <broonie@kernel.org>
To: Michael Welling <mwelling@ieee.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Fionn Cleary <clearyf@tcd.ie>, Wolfram Sang <wsa@the-dreams.de>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message
Date: Wed, 14 Oct 2015 11:56:59 +0100 [thread overview]
Message-ID: <20151014105659.GU14956@sirena.org.uk> (raw)
In-Reply-To: <20151009142451.GA25376@deathstar>
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
On Fri, Oct 09, 2015 at 09:24:51AM -0500, Michael Welling wrote:
> On Fri, Oct 09, 2015 at 12:38:10PM +0100, Mark Brown wrote:
> > On Thu, Oct 08, 2015 at 10:21:05AM -0500, Michael Welling wrote:
> > > On Thu, Oct 08, 2015 at 04:45:00PM +0200, Neil Armstrong wrote:
> > > What is the point of doing this void cast below?
> > > Avoiding compiler warning perhaps?
> > > Perhaps you can __maybe_unused for the variable instead?
> > > > + /* Ignore message */
> > > > + (void)msg;
> > You shouldn't need it at all, but yes if there is a good reason to mark
> > something as unused the above annotation is better.
> Which one?
__maybe_unused.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-10-14 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 14:45 Neil Armstrong
2015-10-08 15:21 ` Michael Welling
2015-10-09 11:38 ` Mark Brown
2015-10-09 14:24 ` Michael Welling
2015-10-14 10:56 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151014105659.GU14956@sirena.org.uk \
--to=broonie@kernel.org \
--cc=clearyf@tcd.ie \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mwelling@ieee.org \
--cc=narmstrong@baylibre.com \
--cc=sre@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®