From: Greg KH <greg@kroah.com>
To: Stefan Achatz <erazor_de@users.sourceforge.net>
Cc: jkosina@suse.cz, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: roccat: Deprecating most Roccat sysfs attributes
Date: Thu, 15 Oct 2015 11:49:44 -0700 [thread overview]
Message-ID: <20151015184944.GA1226@kroah.com> (raw)
In-Reply-To: <1444921209.2900.17.camel@neuromancer.tessier-ashpool>
On Thu, Oct 15, 2015 at 05:00:09PM +0200, Stefan Achatz wrote:
> Deprecates all Roccat sysfs attributes except the ones for the old Kone by moving
> abi descriptions from testing to obsolete.
> For most devices everything can be done using the hidraw ioctls HIDIOCGFEATURE
> and HIDIOCSFEATURE, so I would suggest future removal of device specific drivers.
> The userspace tools don't use these attributes for a year now.
> The first Kone is not fully HID-compliant and will still need a module.
>
> Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
> ---
> .../ABI/obsolete/sysfs-driver-hid-roccat-arvo | 53 ++++++
> .../ABI/obsolete/sysfs-driver-hid-roccat-isku | 153 ++++++++++++++++++
> .../ABI/obsolete/sysfs-driver-hid-roccat-koneplus | 99 +++++++++++-
> .../ABI/obsolete/sysfs-driver-hid-roccat-konepure | 105 ++++++++++++
> .../ABI/obsolete/sysfs-driver-hid-roccat-kovaplus | 50 ++++++
> .../ABI/obsolete/sysfs-driver-hid-roccat-lua | 7 +
> .../ABI/obsolete/sysfs-driver-hid-roccat-pyra | 50 ++++++
> .../ABI/obsolete/sysfs-driver-hid-roccat-ryos | 178 +++++++++++++++++++++
> .../ABI/obsolete/sysfs-driver-hid-roccat-savu | 76 +++++++++
> .../ABI/testing/sysfs-driver-hid-roccat-arvo | 53 ------
> .../ABI/testing/sysfs-driver-hid-roccat-isku | 153 ------------------
> .../ABI/testing/sysfs-driver-hid-roccat-koneplus | 96 -----------
> .../ABI/testing/sysfs-driver-hid-roccat-konepure | 105 ------------
> .../ABI/testing/sysfs-driver-hid-roccat-kovaplus | 49 ------
> .../ABI/testing/sysfs-driver-hid-roccat-lua | 7 -
> .../ABI/testing/sysfs-driver-hid-roccat-pyra | 49 ------
> .../ABI/testing/sysfs-driver-hid-roccat-ryos | 178 ---------------------
> .../ABI/testing/sysfs-driver-hid-roccat-savu | 76 ---------
> 18 files changed, 770 insertions(+), 767 deletions(-)
> create mode 100644 Documentation/ABI/obsolete/sysfs-driver-hid-roccat-arvo
> create mode 100644 Documentation/ABI/obsolete/sysfs-driver-hid-roccat-isku
> create mode 100644 Documentation/ABI/obsolete/sysfs-driver-hid-roccat-konepure
> create mode 100644 Documentation/ABI/obsolete/sysfs-driver-hid-roccat-lua
> create mode 100644 Documentation/ABI/obsolete/sysfs-driver-hid-roccat-ryos
> create mode 100644 Documentation/ABI/obsolete/sysfs-driver-hid-roccat-savu
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-arvo
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-isku
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-koneplus
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-konepure
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-kovaplus
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-lua
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-pyra
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-ryos
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-savu
If you make your patch with 'git format-patch -M' we can see the files
being moved much easier than deleting and adding the files.
thanks,
greg k-h
next prev parent reply other threads:[~2015-10-15 18:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 15:00 Stefan Achatz
2015-10-15 18:49 ` Greg KH [this message]
2015-10-17 13:10 ` [PATCH] HID: roccat: Fixed resubmit: " Stefan Achatz
2015-10-17 15:41 ` Greg KH
2015-10-21 9:55 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015184944.GA1226@kroah.com \
--to=greg@kroah.com \
--cc=erazor_de@users.sourceforge.net \
--cc=jkosina@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome