From: Greg KH <greg@kroah.com>
To: Stefan Achatz <erazor_de@users.sourceforge.net>
Cc: jkosina@suse.cz, linux-api@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: roccat: Fixed resubmit: Deprecating most Roccat sysfs attributes
Date: Sat, 17 Oct 2015 08:41:02 -0700 [thread overview]
Message-ID: <20151017154102.GC4059@kroah.com> (raw)
In-Reply-To: <1445087428.2322.10.camel@neuromancer.tessier-ashpool>
On Sat, Oct 17, 2015 at 03:10:28PM +0200, Stefan Achatz wrote:
> Deprecates all Roccat sysfs attributes except the ones for the old Kone by moving
> abi descriptions from testing to obsolete.
> For most devices everything can be done using the hidraw ioctls HIDIOCGFEATURE
> and HIDIOCSFEATURE, so I would suggest future removal of device specific drivers.
> The userspace tools don't use these attributes for a year now.
> The first Kone is not fully HID-compliant and will still need a module.
>
> Fix: Resubmitting this patch, now done with 'git format-patch -M' like Greg KH suggested.
Nit, there should be a 'v2' in the [] area of the subject line, and this
line shoudl be below the --- line so it doesn't show up in the
changelog.
I don't know if Jiri wants this to be resent because of this or not, I
know I would require it...
thanks,
greg k-h
next prev parent reply other threads:[~2015-10-17 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 15:00 [PATCH] HID: roccat: " Stefan Achatz
2015-10-15 18:49 ` Greg KH
2015-10-17 13:10 ` [PATCH] HID: roccat: Fixed resubmit: " Stefan Achatz
2015-10-17 15:41 ` Greg KH [this message]
2015-10-21 9:55 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151017154102.GC4059@kroah.com \
--to=greg@kroah.com \
--cc=erazor_de@users.sourceforge.net \
--cc=jkosina@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome