From: Mark Brown <broonie@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
kernel@pengutronix.de, alkml@pengutronix.de
Subject: Re: [PATCH 6/8] regulator: core: Propagate voltage changes to supply regulators
Date: Fri, 16 Oct 2015 17:55:22 +0100 [thread overview]
Message-ID: <20151016165522.GU14956@sirena.org.uk> (raw)
In-Reply-To: <1444733131-26995-7-git-send-email-s.hauer@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 583 bytes --]
On Tue, Oct 13, 2015 at 12:45:29PM +0200, Sascha Hauer wrote:
> + best_supply_uV = regulator_get_voltage_floor(regulator, min_uV);
> + if (best_supply_uV < 0) {
> + ret = best_supply_uV;
> + goto out2;
> + }
Now I look at the user here this is just the map voltage operation. We
could even refactor...
> ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
> if (ret < 0)
> goto out2;
...do_set_voltage() so that we only do the mapping once, though that
gets tricky as we still support devices that don't have mapping
configured :/ .
Otherwise this looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-16 16:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 10:45 [PATCH v2] regulator: " Sascha Hauer
2015-10-13 10:45 ` [PATCH 1/8] regulator: core: create unlocked version of regulator_list_voltage Sascha Hauer
2015-10-16 15:26 ` Mark Brown
2015-10-13 10:45 ` [PATCH 2/8] regulator: core: create unlocked version of regulator_set_voltage Sascha Hauer
2015-10-16 17:04 ` Applied "regulator: core: create unlocked version of regulator_set_voltage" to the regulator tree Mark Brown
2015-10-13 10:45 ` [PATCH 3/8] regulator: introduce min_dropout_uv Sascha Hauer
2015-10-16 16:11 ` Mark Brown
2015-10-16 16:41 ` Applied "regulator: introduce min_dropout_uv" to the regulator tree Mark Brown
2015-10-16 16:57 ` Mark Brown
2015-10-13 10:45 ` [PATCH 4/8] regulator: core: introduce function to lock regulators and its supplies Sascha Hauer
2015-10-13 10:45 ` [PATCH 5/8] regulator: introduce regulator_get_voltage_floor Sascha Hauer
2015-10-16 16:50 ` Mark Brown
2015-10-20 12:26 ` Sascha Hauer
2015-10-13 10:45 ` [PATCH 6/8] regulator: core: Propagate voltage changes to supply regulators Sascha Hauer
2015-10-16 16:55 ` Mark Brown [this message]
2015-10-13 10:45 ` [PATCH 7/8] regulator: i.MX anatop: Allow supply regulator Sascha Hauer
2015-10-13 10:45 ` [PATCH 8/8] ARM: i.MX6 Phytec PFLA02: Add supplies for the SoC internal regulators Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151016165522.GU14956@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alkml@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®