From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, kernel@pengutronix.de,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/4] rtc: pcf2127: fix reading uninitialized value on RTC_READ_VL ioctl
Date: Sun, 18 Oct 2015 02:14:28 +0200 [thread overview]
Message-ID: <20151018001428.GV3421@piout.net> (raw)
In-Reply-To: <1443777442-15920-2-git-send-email-u.kleine-koenig@pengutronix.de>
On 02/10/2015 at 11:17:19 +0200, Uwe Kleine-König wrote :
> The flag reported on the RTC_READ_VL ioctl is only initialized when the
> date is read out. So the voltage low value doesn't represent reality but
> the status at the time the date was read (or 0 if the date was not read
> yet).
>
> Moreover when userspace requests a value via an ioctl there is no added
> benefit to also make a prosa representation of this (and other) values
> appear in the kernel log so remove the calls to dev_info and the driver
> data members to track their state.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-18 0:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 9:17 [PATCH v1 0/4] rtc: pcf2127: a fix, a cleanup and two questionable features Uwe Kleine-König
2015-10-02 9:17 ` [PATCH v1 1/4] rtc: pcf2127: fix reading uninitialized value on RTC_READ_VL ioctl Uwe Kleine-König
2015-10-18 0:14 ` Alexandre Belloni [this message]
2015-10-02 9:17 ` [PATCH v1 2/4] rtc: pcf2127: remove useless driver version Uwe Kleine-König
2015-10-18 0:14 ` Alexandre Belloni
2015-10-02 9:17 ` [PATCH v1 3/4 RFC] rtc: pcf2127: implement reading battery status bits Uwe Kleine-König
2015-10-02 9:17 ` [PATCH v1 4/4 RFC] rtc: pcf2127: implement access to nvram Uwe Kleine-König
2015-10-14 23:50 ` [PATCH v1 0/4] rtc: pcf2127: a fix, a cleanup and two questionable features Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151018001428.GV3421@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome