[PATCH 0/1] btrfs: remove an unsed varialbe first_index

[PATCH 0/1] btrfs: remove an unsed varialbe first_index

[Shan Hai]

This patch removes an unused variable from file.c for code clearance
purpose.

Thanks
Shan Hai

[PATCH 1/1] btrfs/file.c: remove an unsed varialbe first_index

[Shan Hai]

From: Shan Hai <shan.hai@windriver.com>

The commit b37392ea86761 ("Btrfs: cleanup unnecessary parameter
and variant of prepare_pages()") makes it redundant.

Signed-off-by: Shan Hai <haishan.bai@hotmail.com>
---
 fs/btrfs/file.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
index b823fac..b6695c4 100644
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
@@ -1469,7 +1469,6 @@ static noinline ssize_t __btrfs_buffered_write(struct file *file,
 	u64 release_bytes = 0;
 	u64 lockstart;
 	u64 lockend;
-	unsigned long first_index;
 	size_t num_written = 0;
 	int nrptrs;
 	int ret = 0;
@@ -1485,8 +1484,6 @@ static noinline ssize_t __btrfs_buffered_write(struct file *file,
 	if (!pages)
 		return -ENOMEM;
 
-	first_index = pos >> PAGE_CACHE_SHIFT;
-
 	while (iov_iter_count(i) > 0) {
 		size_t offset = pos & (PAGE_CACHE_SIZE - 1);
 		size_t write_bytes = min(iov_iter_count(i),
-- 
2.1.4

Re: [PATCH 1/1] btrfs/file.c: remove an unsed varialbe first_index

[David Sterba]

On Mon, Sep 21, 2015 at 11:40:57AM +0800, Shan Hai wrote:
> From: Shan Hai <shan.hai@windriver.com>
> 
> The commit b37392ea86761 ("Btrfs: cleanup unnecessary parameter
> and variant of prepare_pages()") makes it redundant.
> 
> Signed-off-by: Shan Hai <haishan.bai@hotmail.com>

Reviewed-by: David Sterba <dsterba@suse.com>