From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Borislav Petkov <bp@suse.de>,
Brendan Gregg <brendan.d.gregg@gmail.com>,
Chandler Carruth <chandlerc@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Stephane Eranian <eranian@google.com>,
Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 2/2] perf tools: Improve call graph documents and help messages
Date: Thu, 22 Oct 2015 13:26:28 -0300 [thread overview]
Message-ID: <20151022162628.GI2455@kernel.org> (raw)
In-Reply-To: <CAM9d7cjmVKpyPRnX=Qv4k7q1a_z21iOi_y1xOe05FYzT5QyGwQ@mail.gmail.com>
Em Fri, Oct 23, 2015 at 01:05:45AM +0900, Namhyung Kim escreveu:
> On Thu, Oct 22, 2015 at 11:46 PM, Arnaldo Carvalho de Melo
> > At some point it would be nice to be able to use:
> >
> > perf top --call-graph caller
> >
> > And have that be equivalent to:
> >
> > perf top --callgraph fp,graph,0.5,caller,function
> >
> > I.e. change just one of the defaults.
> ?? That's supported already by commit e8232f1ad468 ("perf report:
> Relax -g option parsing not to limit the option order")..
Ok, that "point" already happened, good! ;-)
> > But I think that how you did it is backwards compatible, i.e. adding
> > stuff just to the end.
> > Ah, noticed you forgot to update the 'top' man page
>
> Heh, I just added below in the previous patch.. ;-)
>
> "See `--call-graph` section in perf-record and perf-report man pages
> for details."
Okay then, should be enough :-)
> Thanks,
> Namhyung
>
> /me goes to bed now...
G'nite!
next prev parent reply other threads:[~2015-10-22 16:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 14:28 [PATCH 1/2] perf tools: Setup pager when printing usage and help Namhyung Kim
2015-10-22 14:28 ` [PATCH 2/2] perf tools: Improve call graph documents and help messages Namhyung Kim
2015-10-22 14:46 ` Arnaldo Carvalho de Melo
2015-10-22 16:05 ` Namhyung Kim
2015-10-22 16:26 ` Arnaldo Carvalho de Melo [this message]
2015-10-22 16:28 ` Frederic Weisbecker
2015-10-22 18:37 ` Arnaldo Carvalho de Melo
2015-10-23 8:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-10-23 9:03 ` Ingo Molnar
2015-10-24 15:52 ` Namhyung Kim
2015-10-25 9:19 ` Ingo Molnar
2015-10-22 14:41 ` [PATCH 1/2] perf tools: Setup pager when printing usage and help Arnaldo Carvalho de Melo
2015-10-22 15:58 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022162628.GI2455@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=adrian.hunter@intel.com \
--cc=bp@suse.de \
--cc=brendan.d.gregg@gmail.com \
--cc=chandlerc@gmail.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome