From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Borislav Petkov <bp@suse.de>,
Brendan Gregg <brendan.d.gregg@gmail.com>,
Chandler Carruth <chandlerc@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Stephane Eranian <eranian@google.com>,
Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 2/2] perf tools: Improve call graph documents and help messages
Date: Thu, 22 Oct 2015 15:37:57 -0300 [thread overview]
Message-ID: <20151022183757.GA20144@kernel.org> (raw)
In-Reply-To: <1445524112-5201-2-git-send-email-namhyung@kernel.org>
Em Thu, Oct 22, 2015 at 11:28:32PM +0900, Namhyung Kim escreveu:
> The --call-graph option is complex so we should provide better guide for
> users. Also change help message to be consistent with config option
> names. Now perf top will show help like below:
>
> $ perf top --call-graph
> Error: option `call-graph' requires a value
>
> Usage: perf top [<options>]
>
> --call-graph <record_mode[,record_size],print_type,threshold[,print_limit],order,sort_key[,branch]>
> setup and enables call-graph (stack chain/backtrace):
>
> record_mode: call graph recording mode (fp|dwarf|lbr)
> record_size: if record_mode is 'dwarf', max size of stack recording (<bytes>)
> default: 8192 (bytes)
> print_type: call graph printing style (graph|flat|fractal|none)
> threshold: minimum call graph inclusion threshold (<percent>)
> print_limit: maximum number of call graph entry (<number>)
> order: call graph order (caller|callee)
> sort_key: call graph sort key (function|address)
> branch: include last branch info to call graph (branch)
>
> Default: fp,graph,0.5,caller,function
Applied.
next prev parent reply other threads:[~2015-10-22 18:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 14:28 [PATCH 1/2] perf tools: Setup pager when printing usage and help Namhyung Kim
2015-10-22 14:28 ` [PATCH 2/2] perf tools: Improve call graph documents and help messages Namhyung Kim
2015-10-22 14:46 ` Arnaldo Carvalho de Melo
2015-10-22 16:05 ` Namhyung Kim
2015-10-22 16:26 ` Arnaldo Carvalho de Melo
2015-10-22 16:28 ` Frederic Weisbecker
2015-10-22 18:37 ` Arnaldo Carvalho de Melo [this message]
2015-10-23 8:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-10-23 9:03 ` Ingo Molnar
2015-10-24 15:52 ` Namhyung Kim
2015-10-25 9:19 ` Ingo Molnar
2015-10-22 14:41 ` [PATCH 1/2] perf tools: Setup pager when printing usage and help Arnaldo Carvalho de Melo
2015-10-22 15:58 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022183757.GA20144@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=adrian.hunter@intel.com \
--cc=bp@suse.de \
--cc=brendan.d.gregg@gmail.com \
--cc=chandlerc@gmail.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome