From: Catalin Marinas <catalin.marinas@arm.com>
To: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm: kmemleak: mark kmemleak_init prototype as __init
Date: Wed, 28 Oct 2015 16:02:19 +0000 [thread overview]
Message-ID: <20151028160219.GC8899@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <1436060821-29353-1-git-send-email-nicolas.iooss_linux@m4x.org>
On Sun, Jul 05, 2015 at 02:47:01AM +0100, Nicolas Iooss wrote:
> kmemleak_init() definition in mm/kmemleak.c is marked __init but its
> prototype in include/linux/kmemleak.h is marked __ref since commit
> a6186d89c913 ("kmemleak: Mark the early log buffer as __initdata").
>
> This causes a section mismatch which is reported as a warning when
> building with clang -Wsection, because kmemleak_init() is declared in
> section .ref.text but defined in .init.text.
>
> Fix this by marking kmemleak_init() prototype __init.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
> include/linux/kmemleak.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/kmemleak.h b/include/linux/kmemleak.h
> index d0a1f99e24e3..4894c6888bc6 100644
> --- a/include/linux/kmemleak.h
> +++ b/include/linux/kmemleak.h
> @@ -25,7 +25,7 @@
>
> #ifdef CONFIG_DEBUG_KMEMLEAK
>
> -extern void kmemleak_init(void) __ref;
> +extern void kmemleak_init(void) __init;
> extern void kmemleak_alloc(const void *ptr, size_t size, int min_count,
> gfp_t gfp) __ref;
> extern void kmemleak_alloc_percpu(const void __percpu *ptr, size_t size,
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
I forgot about this patch. Andrew, could you please queue this patch for
4.4? Thanks.
--
Catalin
next prev parent reply other threads:[~2015-10-28 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 1:47 Nicolas Iooss
2015-10-28 16:02 ` Catalin Marinas [this message]
2015-12-04 10:19 Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028160219.GC8899@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.iooss_linux@m4x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®