* [PATCH] mm: kmemleak: mark kmemleak_init prototype as __init
@ 2015-07-05 1:47 Nicolas Iooss
2015-10-28 16:02 ` Catalin Marinas
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Iooss @ 2015-07-05 1:47 UTC (permalink / raw)
To: Catalin Marinas; +Cc: linux-kernel, Nicolas Iooss
kmemleak_init() definition in mm/kmemleak.c is marked __init but its
prototype in include/linux/kmemleak.h is marked __ref since commit
a6186d89c913 ("kmemleak: Mark the early log buffer as __initdata").
This causes a section mismatch which is reported as a warning when
building with clang -Wsection, because kmemleak_init() is declared in
section .ref.text but defined in .init.text.
Fix this by marking kmemleak_init() prototype __init.
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
include/linux/kmemleak.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/kmemleak.h b/include/linux/kmemleak.h
index d0a1f99e24e3..4894c6888bc6 100644
--- a/include/linux/kmemleak.h
+++ b/include/linux/kmemleak.h
@@ -25,7 +25,7 @@
#ifdef CONFIG_DEBUG_KMEMLEAK
-extern void kmemleak_init(void) __ref;
+extern void kmemleak_init(void) __init;
extern void kmemleak_alloc(const void *ptr, size_t size, int min_count,
gfp_t gfp) __ref;
extern void kmemleak_alloc_percpu(const void __percpu *ptr, size_t size,
--
2.4.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: kmemleak: mark kmemleak_init prototype as __init
2015-07-05 1:47 [PATCH] mm: kmemleak: mark kmemleak_init prototype as __init Nicolas Iooss
@ 2015-10-28 16:02 ` Catalin Marinas
0 siblings, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2015-10-28 16:02 UTC (permalink / raw)
To: Nicolas Iooss; +Cc: linux-kernel, Andrew Morton
On Sun, Jul 05, 2015 at 02:47:01AM +0100, Nicolas Iooss wrote:
> kmemleak_init() definition in mm/kmemleak.c is marked __init but its
> prototype in include/linux/kmemleak.h is marked __ref since commit
> a6186d89c913 ("kmemleak: Mark the early log buffer as __initdata").
>
> This causes a section mismatch which is reported as a warning when
> building with clang -Wsection, because kmemleak_init() is declared in
> section .ref.text but defined in .init.text.
>
> Fix this by marking kmemleak_init() prototype __init.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
> include/linux/kmemleak.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/kmemleak.h b/include/linux/kmemleak.h
> index d0a1f99e24e3..4894c6888bc6 100644
> --- a/include/linux/kmemleak.h
> +++ b/include/linux/kmemleak.h
> @@ -25,7 +25,7 @@
>
> #ifdef CONFIG_DEBUG_KMEMLEAK
>
> -extern void kmemleak_init(void) __ref;
> +extern void kmemleak_init(void) __init;
> extern void kmemleak_alloc(const void *ptr, size_t size, int min_count,
> gfp_t gfp) __ref;
> extern void kmemleak_alloc_percpu(const void __percpu *ptr, size_t size,
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
I forgot about this patch. Andrew, could you please queue this patch for
4.4? Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mm: kmemleak: mark kmemleak_init prototype as __init
@ 2015-12-04 10:19 Catalin Marinas
0 siblings, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2015-12-04 10:19 UTC (permalink / raw)
To: linux-mm; +Cc: Andrew Morton, linux-kernel, Nicolas Iooss
From: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
kmemleak_init() definition in mm/kmemleak.c is marked __init but its
prototype in include/linux/kmemleak.h is marked __ref since commit
a6186d89c913 ("kmemleak: Mark the early log buffer as __initdata").
This causes a section mismatch which is reported as a warning when
building with clang -Wsection, because kmemleak_init() is declared in
section .ref.text but defined in .init.text.
Fix this by marking kmemleak_init() prototype __init.
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
---
I think this patch was missed some time ago, so resending (minor fix).
Thanks,
Catalin
include/linux/kmemleak.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/kmemleak.h b/include/linux/kmemleak.h
index d0a1f99e24e3..4894c6888bc6 100644
--- a/include/linux/kmemleak.h
+++ b/include/linux/kmemleak.h
@@ -25,7 +25,7 @@
#ifdef CONFIG_DEBUG_KMEMLEAK
-extern void kmemleak_init(void) __ref;
+extern void kmemleak_init(void) __init;
extern void kmemleak_alloc(const void *ptr, size_t size, int min_count,
gfp_t gfp) __ref;
extern void kmemleak_alloc_percpu(const void __percpu *ptr, size_t size,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-04 10:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-05 1:47 [PATCH] mm: kmemleak: mark kmemleak_init prototype as __init Nicolas Iooss
2015-10-28 16:02 ` Catalin Marinas
2015-12-04 10:19 Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®