mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Geliang Tang <geliangtang@163.com>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: fix compiler warnings in trace_events.c
Date: Mon, 2 Nov 2015 13:22:45 -0500	[thread overview]
Message-ID: <20151102132245.430223ef@gandalf.local.home> (raw)
In-Reply-To: <b9c3a335e1595c01c1d5e708dc206b9d28c5970c.1446479420.git.geliangtang@163.com>

On Mon,  2 Nov 2015 00:00:43 -0800
Geliang Tang <geliangtang@163.com> wrote:

> Fix the following warnings:
>   kernel/trace/trace_events.c: In function '__ftrace_clear_event_pids':
>   kernel/trace/trace_events.c:579: warning: passing argument 1 of 'unregister_trace_sched_switch' from incompatible pointer type
>   include/trace/events/sched.h:162: note: expected 'void (*)(void *, bool,  struct task_struct *, struct task_struct *)' but argument is of type 'void (*)(void *, struct task_struct *, struct task_struct *)'
>   kernel/trace/trace_events.c:580: warning: passing argument 1 of 'unregister_trace_sched_switch' from incompatible pointer type
>   include/trace/events/sched.h:162: note: expected 'void (*)(void *, bool,  struct task_struct *, struct task_struct *)' but argument is of type 'void (*)(void *, struct task_struct *, struct task_struct *)'
>   kernel/trace/trace_events.c: In function 'ftrace_event_pid_write':
>   kernel/trace/trace_events.c:1724: warning: passing argument 1 of 'register_trace_prio_sched_switch' from incompatible pointer type
>   include/trace/events/sched.h:162: note: expected 'void (*)(void *, bool,  struct task_struct *, struct task_struct *)' but argument is of type 'void (*)(void *, struct task_struct *, struct task_struct *)'
>   kernel/trace/trace_events.c:1726: warning: passing argument 1 of 'register_trace_prio_sched_switch' from incompatible pointer type
>   include/trace/events/sched.h:162: note: expected 'void (*)(void *, bool,  struct task_struct *, struct task_struct *)' but argument is of type 'void (*)(void *, struct task_struct *, struct task_struct *)'
> 
> Signed-off-by: Geliang Tang <geliangtang@163.com>

This is something that Linus is going to have to fix when he merges
both trees. This patch wont work with either of them without the other
already merged.

-- Steve

      reply	other threads:[~2015-11-02 18:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02  8:00 Geliang Tang
2015-11-02 18:22 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151102132245.430223ef@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=geliangtang@163.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®