mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, acme@kernel.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 5/9] perf, tools, stat: Move noise/running printing into printout
Date: Wed, 4 Nov 2015 09:48:54 +0100	[thread overview]
Message-ID: <20151104084854.GG29671@krava.brq.redhat.com> (raw)
In-Reply-To: <1446515428-7450-6-git-send-email-andi@firstfloor.org>

On Mon, Nov 02, 2015 at 05:50:24PM -0800, Andi Kleen wrote:

SNIP

> @@ -729,32 +722,8 @@ static void print_counter_aggr(struct perf_evsel *counter, char *prefix)
>  	if (prefix)
>  		fprintf(output, "%s", prefix);
>  
> -	if (scaled == -1 || !counter->supported) {
> -		fprintf(output, "%*s%s",
> -			csv_output ? 0 : 18,
> -			counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED,
> -			csv_sep);
> -		fprintf(output, "%-*s%s",
> -			csv_output ? 0 : unit_width,
> -			counter->unit, csv_sep);
> -		fprintf(output, "%*s",
> -			csv_output ? 0 : -25,
> -			perf_evsel__name(counter));

so this changed current 'not supported' output:

   <not supported>      stalled-cycles-frontend  
   <not supported>      stalled-cycles-backend   


into

                 0      stalled-cycles-frontend                                     
                 0      stalled-cycles-backend    #   0.00% backend cycles idle     

> -
> -		if (counter->cgrp)
> -			fprintf(output, "%s%s", csv_sep, counter->cgrp->name);

haven't tried with cgroup, but I think that removing
above hunk will not do any good to it..

jirka

> -
> -		print_running(avg_running, avg_enabled);
> -		fputc('\n', output);
> -		return;
> -	}
> -
>  	uval = avg * counter->scale;
> -	printout(-1, 0, counter, uval, prefix);
> -

SNIP

  reply	other threads:[~2015-11-04  8:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03  1:50 perf, tools: Refactor and support interval and CSV metrics v6 Andi Kleen
2015-11-03  1:50 ` [PATCH 1/9] perf, tools, stat: Move sw clock metrics printout to stat-shadow Andi Kleen
2015-11-04  8:15   ` Jiri Olsa
2015-11-08  7:28   ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2015-11-03  1:50 ` [PATCH 2/9] tools, perf, stat: Use common printout faction to avoid duplicated code Andi Kleen
2015-11-04  8:15   ` Jiri Olsa
2015-11-08  7:28   ` [tip:perf/urgent] perf stat: Use common printout function " tip-bot for Andi Kleen
2015-11-03  1:50 ` [PATCH 3/9] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2015-11-04  8:34   ` Jiri Olsa
2015-11-04  8:42   ` Jiri Olsa
2015-11-05  2:43     ` Andi Kleen
2015-11-05  6:52       ` Jiri Olsa
2015-11-05 15:20         ` Andi Kleen
2015-11-03  1:50 ` [PATCH 4/9] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2015-11-03  1:50 ` [PATCH 5/9] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2015-11-04  8:48   ` Jiri Olsa [this message]
2015-11-03  1:50 ` [PATCH 6/9] perf, tools, stat: Implement CSV metrics output Andi Kleen
2015-11-03  1:50 ` [PATCH 7/9] perf, tools, stat: Move non counting counter printing to printout Andi Kleen
2015-11-03  1:50 ` [PATCH 8/9] perf, tools: Support metrics in --per-core/socket mode Andi Kleen
2015-11-03  1:50 ` [PATCH 9/9] perf, tools, stat: Document CSV format in manpage Andi Kleen
2015-11-03  7:46 ` perf, tools: Refactor and support interval and CSV metrics v6 Jiri Olsa
2015-11-05  2:43   ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2015-10-23 23:59 perf, tools: Refactor and support interval and CSV metrics v5 Andi Kleen
2015-10-23 23:59 ` [PATCH 5/9] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2015-10-26 15:32   ` Jiri Olsa
2015-10-27  2:42     ` Andi Kleen
2015-09-21 23:49 perf, tools: Refactor and support interval and CSV metrics v4 Andi Kleen
2015-09-21 23:50 ` [PATCH 5/9] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2015-09-24  9:01   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151104084854.GG29671@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®