From: David Miller <davem@davemloft.net>
To: mans@mansr.com
Cc: romieu@fr.zoreil.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, slash.tmp@free.fr
Subject: Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller
Date: Wed, 11 Nov 2015 14:48:40 -0500 (EST) [thread overview]
Message-ID: <20151111.144840.430771235700359719.davem@davemloft.net> (raw)
In-Reply-To: <yw1x37wcnxcm.fsf@unicorn.mansr.com>
From: Måns Rullgård <mans@mansr.com>
Date: Wed, 11 Nov 2015 19:35:05 +0000
>> I don't think it's silly at all.
>
> I'm sure I read somewhere that the time spent spinning on a lock should
> be kept as small as possible.
>
>> And unless you can measure it making a difference, don't knock the idea.
>
> I tried using netif_tx_lock() in the IRQ handler instead, and it locked
> up solid. Clearly that was the wrong thing to do.
Oh that's right, it's a BH lock not an IRQ one.
Yet another argument for doing everything in ->poll(), thus making all
operations outside of NAPI scheduling run in software interrupt
context, and therefore being able to make use of the TXQ lock for
this.
next prev parent reply other threads:[~2015-11-11 19:48 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 16:14 Mans Rullgard
2015-11-10 17:55 ` Eric Dumazet
2015-11-10 18:05 ` Måns Rullgård
2015-11-10 20:04 ` David Miller
2015-11-10 20:53 ` Måns Rullgård
2015-11-10 21:06 ` David Miller
2015-11-10 21:21 ` Måns Rullgård
2015-11-10 21:51 ` Eric Dumazet
2015-11-11 13:41 ` Mason
2015-11-11 13:54 ` Måns Rullgård
2015-11-11 14:10 ` Eric Dumazet
2015-11-11 14:06 ` Eric Dumazet
2015-11-10 17:58 ` Eric Dumazet
2015-11-10 18:07 ` Måns Rullgård
2015-11-10 19:13 ` Mason
2015-11-10 19:25 ` Måns Rullgård
2015-11-12 13:33 ` Mason
2015-11-12 14:04 ` Måns Rullgård
2015-11-12 16:19 ` Mason
2015-11-12 16:57 ` Måns Rullgård
2015-11-12 17:20 ` Måns Rullgård
2015-11-10 22:09 ` Andy Shevchenko
2015-11-10 22:34 ` Måns Rullgård
2015-11-10 22:40 ` Andy Shevchenko
2015-11-10 23:07 ` Måns Rullgård
2015-11-11 0:36 ` Andy Shevchenko
2015-11-11 0:44 ` Måns Rullgård
2015-11-10 23:34 ` Francois Romieu
2015-11-11 0:40 ` Måns Rullgård
2015-11-11 2:11 ` David Miller
2015-11-11 12:22 ` Måns Rullgård
2015-11-11 13:04 ` Måns Rullgård
2015-11-11 13:29 ` Eric Dumazet
2015-11-11 13:48 ` Måns Rullgård
2015-11-11 14:09 ` Eric Dumazet
2015-11-11 14:15 ` Måns Rullgård
2015-11-11 14:35 ` Måns Rullgård
2015-11-11 14:44 ` Eric Dumazet
2015-11-11 14:42 ` Eric Dumazet
2015-11-11 16:24 ` David Miller
2015-11-11 18:25 ` Måns Rullgård
2015-11-11 19:02 ` David Miller
2015-11-11 19:09 ` Måns Rullgård
2015-11-11 19:13 ` David Miller
2015-11-11 19:17 ` Måns Rullgård
2015-11-11 19:19 ` David Miller
2015-11-11 19:25 ` Måns Rullgård
2015-11-11 19:26 ` David Miller
2015-11-11 19:35 ` Måns Rullgård
2015-11-11 19:48 ` David Miller [this message]
2015-11-11 20:47 ` Måns Rullgård
2015-11-11 16:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111.144840.430771235700359719.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®