From: "Måns Rullgård" <mans@mansr.com>
To: Mason <slash.tmp@free.fr>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Daniel Mack <daniel@zonque.org>,
"David S. Miller" <davem@davemloft.net>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller
Date: Thu, 12 Nov 2015 17:20:29 +0000 [thread overview]
Message-ID: <yw1xziyjkuci.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <yw1x4mgrm9ys.fsf@unicorn.mansr.com> (=?iso-8859-1?Q?=22M=E5n?= =?iso-8859-1?Q?s_Rullg=E5rd=22's?= message of "Thu, 12 Nov 2015 16:57:47 +0000")
Måns Rullgård <mans@mansr.com> writes:
> Mason <slash.tmp@free.fr> writes:
>
>> [ CCing a few knowledgeable people ]
>>
>> Despite the subject, this is about an Atheros 8035 PHY :-)
>>
>> On 12/11/2015 15:04, Måns Rullgård wrote:
>>
>>> Mason wrote:
>>>
>>>> BTW, you're not using the PHY IRQ, right? I think I remember you saying
>>>> it didn't work reliably?
>>>
>>> It doesn't seem to be wired up on any of my boards, or there's some
>>> magic required to activate it that I'm unaware of.
>>
>> Weird. The board schematics for the 1172 show Tango ETH0_MDINT# pin
>> properly connected to AR8035 INT pin (pin 20).
>
> I have a different board.
>
>> <Thinking out loud>
>>
>> http://www.redeszone.net/app/uploads/2014/04/AR8035.pdf
>>
>> INT pin 20
>> I/O, D, PD
>> Interrupt Signal to System; default OD-gate, needs an external
>> 10Kohm pull-up, active low; can be configured to I/O by register,
>> active high.
>>
>> 4.1.17 Interrupt Enable
>> Offset: 0x12
>> Mode: Read/Write
>> Hardware Reset: 0
>>
>> Strange... it looks like AT803X_INER and AT803X_INTR_ENABLE refer to
>> the same "Interrupt Enable" register?
>
> Seems like someone missed that it was already defined.
>
>> In fact, AT803X_INER_INIT == 0xec00 makes sense for register 0x12:
>> link success/fail, speed/duplex changed, autoneg error
>>
>> Looks like at803x_config_intr() is used for 8031, but not for 8035...
>>
>> Relevant commit:
>> 77a9939426f7a "phy/at8031: enable at8031 to work on interrupt mode"
>>
>> If I add .config_intr and .ack_interrupt to the 8035 struct, then I get
>> (also added some traces)
>
> I tried that just now, and I get nothing. What interrupt did you
> specify in your device tree?
It works with the interrupt set to trigger on rising edge.
--
Måns Rullgård
mans@mansr.com
next prev parent reply other threads:[~2015-11-12 17:20 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 16:14 Mans Rullgard
2015-11-10 17:55 ` Eric Dumazet
2015-11-10 18:05 ` Måns Rullgård
2015-11-10 20:04 ` David Miller
2015-11-10 20:53 ` Måns Rullgård
2015-11-10 21:06 ` David Miller
2015-11-10 21:21 ` Måns Rullgård
2015-11-10 21:51 ` Eric Dumazet
2015-11-11 13:41 ` Mason
2015-11-11 13:54 ` Måns Rullgård
2015-11-11 14:10 ` Eric Dumazet
2015-11-11 14:06 ` Eric Dumazet
2015-11-10 17:58 ` Eric Dumazet
2015-11-10 18:07 ` Måns Rullgård
2015-11-10 19:13 ` Mason
2015-11-10 19:25 ` Måns Rullgård
2015-11-12 13:33 ` Mason
2015-11-12 14:04 ` Måns Rullgård
2015-11-12 16:19 ` Mason
2015-11-12 16:57 ` Måns Rullgård
2015-11-12 17:20 ` Måns Rullgård [this message]
2015-11-10 22:09 ` Andy Shevchenko
2015-11-10 22:34 ` Måns Rullgård
2015-11-10 22:40 ` Andy Shevchenko
2015-11-10 23:07 ` Måns Rullgård
2015-11-11 0:36 ` Andy Shevchenko
2015-11-11 0:44 ` Måns Rullgård
2015-11-10 23:34 ` Francois Romieu
2015-11-11 0:40 ` Måns Rullgård
2015-11-11 2:11 ` David Miller
2015-11-11 12:22 ` Måns Rullgård
2015-11-11 13:04 ` Måns Rullgård
2015-11-11 13:29 ` Eric Dumazet
2015-11-11 13:48 ` Måns Rullgård
2015-11-11 14:09 ` Eric Dumazet
2015-11-11 14:15 ` Måns Rullgård
2015-11-11 14:35 ` Måns Rullgård
2015-11-11 14:44 ` Eric Dumazet
2015-11-11 14:42 ` Eric Dumazet
2015-11-11 16:24 ` David Miller
2015-11-11 18:25 ` Måns Rullgård
2015-11-11 19:02 ` David Miller
2015-11-11 19:09 ` Måns Rullgård
2015-11-11 19:13 ` David Miller
2015-11-11 19:17 ` Måns Rullgård
2015-11-11 19:19 ` David Miller
2015-11-11 19:25 ` Måns Rullgård
2015-11-11 19:26 ` David Miller
2015-11-11 19:35 ` Måns Rullgård
2015-11-11 19:48 ` David Miller
2015-11-11 20:47 ` Måns Rullgård
2015-11-11 16:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xziyjkuci.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®