From: Steven Rostedt <rostedt@goodmis.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/rt: hide push_irq_work_func declaration
Date: Thu, 12 Nov 2015 10:49:13 -0500 [thread overview]
Message-ID: <20151112104913.4f68a92c@gandalf.local.home> (raw)
In-Reply-To: <4129441.9nXLnMzV6v@wuerfel>
On Thu, 12 Nov 2015 16:14:06 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 12 November 2015 09:47:39 Steven Rostedt wrote:
> > > -#ifdef CONFIG_SMP
> > > +#if IS_ENABLED(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI)
> >
> > Why IS_ENABLED() and not defined()?
> >
> > #if defined(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI)
> >
> > I thought IS_ENABLED() is used for C code, like:
> >
> > if (IS_ENABLED(CONFIG_SMP)) {
> > [...]
> > }
>
> "#if IS_ENABLED(CONFIG_foo)" has another property, which is
> to evaluate to true when Kconfig has set the symbol to "=m".
> Obviously that cannot happen for CONFIG_SMP, but some
> maintainers prefer using IS_ENABLED() consistently for all
> config symbols.
>
> I don't care much either way, and it's easily changed if
> we still want the patch and you prefer a plain #if defined().
>
For this instance, I do prefer the "defined()" version. I can
understand the IS_ENABLED() for module configs. But I don't see the
need to make all #if's use it. Maybe because I don't deal with module
configs much.
Anyway, this patch should probably go in now as a current "fix", and
the redesign should be looked at as well, but that's unrelated to your
arch, and you shouldn't need to worry about it.
Thanks,
-- Steve
next prev parent reply other threads:[~2015-11-12 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 14:22 Arnd Bergmann
2015-11-12 14:47 ` Steven Rostedt
2015-11-12 15:14 ` Arnd Bergmann
2015-11-12 15:49 ` Steven Rostedt [this message]
2015-11-12 14:53 ` Peter Zijlstra
2015-11-12 15:16 ` Steven Rostedt
2015-11-12 16:19 ` [PATCH v2] " Arnd Bergmann
2015-11-12 16:27 ` Steven Rostedt
2015-11-23 16:17 ` [tip:sched/core] sched/rt: Hide the push_irq_work_func() declaration tip-bot for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112104913.4f68a92c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®