From: David Miller <davem@davemloft.net>
To: Ben@Benjojo.co.uk
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
ben+patches@Benjojo.co.uk
Subject: Re: [PATCH v2 net] raw: increment correct SNMP counters for ICMP messages
Date: Mon, 16 Nov 2015 15:09:00 -0500 (EST) [thread overview]
Message-ID: <20151116.150900.193988253386004564.davem@davemloft.net> (raw)
In-Reply-To: <20151114151358.GA11387@benjojo.co.uk>
From: Ben Cartwright-Cox <Ben@Benjojo.co.uk>
Date: Sat, 14 Nov 2015 15:13:58 +0000
> Sending ICMP packets with raw sockets ends up in the SNMP counters
> logging the type as the first byte of the IPv4 header rather than
> the ICMP header. This is fixed by adding the IP Header Length to
> the casting into a icmphdr struct.
>
> Signed-off-by: Ben Cartwright-Cox <ben@benjojo.co.uk>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
next prev parent reply other threads:[~2015-11-16 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 15:13 Ben Cartwright-Cox
2015-11-16 20:09 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-10-12 14:53 Ben Cartwright-Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116.150900.193988253386004564.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ben@Benjojo.co.uk \
--cc=ben+patches@Benjojo.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®