From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ftrace/x86: Fix missing ops arg on static function tracing
Date: Mon, 16 Nov 2015 11:25:08 -0500 [thread overview]
Message-ID: <20151116112508.6e6f3a5d@gandalf.local.home> (raw)
In-Reply-To: <20151116105453.3de46887@gandalf.local.home>
On Mon, 16 Nov 2015 10:54:53 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> This isn't needed, nor will the parameter be used if added. A comment
> should probably be added here instead.
>
> /*
> * When DYNAMIC_FTRACE is not defined, ARCH_SUPPORTS_FTRACE_OPS is not
> * set (see include/asm/ftrace.h). Only the ip and parent ip are used
Probably should also add "and include/linux/ftrace.h" as that's where
the ARCH_SUPPORTS_FTRACE_OPS is described.
-- Steve
> * and the list function is called when function tracing is enabled.
> */
>
next prev parent reply other threads:[~2015-11-16 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 9:32 Namhyung Kim
2015-11-16 15:54 ` Steven Rostedt
2015-11-16 15:57 ` Steven Rostedt
2015-11-16 16:25 ` Steven Rostedt [this message]
2015-11-16 23:44 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116112508.6e6f3a5d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®