mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Kyeongdon Kim <kyeongdon.kim@lge.com>,
	ngupta@vflare.org, sergey.senozhatsky.work@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] zram: try vmalloc() after kmalloc()
Date: Mon, 23 Nov 2015 15:40:29 -0800	[thread overview]
Message-ID: <20151123154029.ec1cb910a827ddf51aa986c4@linux-foundation.org> (raw)
In-Reply-To: <20151123232857.GB3882@blaptop>

On Tue, 24 Nov 2015 08:28:57 +0900 Minchan Kim <minchan@kernel.org> wrote:

> > What's the reasoning behind the modification to the gfp flags?
> > 
> > It clears __GFP_FS, __GFP_IO and even __GFP_WAIT.  I suspect the latter
> > two (at least) can be retained.  And given that vmalloc() uses
> 
> This function is used in swapout and fs write path so we couldn't use
> those flags.

We can use __GFP_RECLAIM (used to be __GFP_WAIT).  That permits the
allocation to wait for in-flight IO to complete and to reclaim clean
pagecache.


  reply	other threads:[~2015-11-23 23:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23  6:21 Kyeongdon Kim
2015-11-23  6:35 ` Minchan Kim
2015-11-23  7:26   ` Sergey Senozhatsky
2015-11-23 22:52 ` Andrew Morton
2015-11-23 23:28   ` Minchan Kim
2015-11-23 23:40     ` Andrew Morton [this message]
2015-11-24  0:35       ` Minchan Kim
2015-11-24  1:06         ` Sergey Senozhatsky
2015-11-24  3:56           ` Minchan Kim
2015-11-24  8:09     ` Kyeongdon Kim
2015-11-24  8:15       ` Minchan Kim
2015-11-24  7:56   ` Kyeongdon Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151123154029.ec1cb910a827ddf51aa986c4@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=kyeongdon.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®