From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 2/3] ftrace: add ftrace-buffer option
Date: Mon, 23 Nov 2015 16:46:43 -0500 [thread overview]
Message-ID: <20151123164643.04f8601d@gandalf.local.home> (raw)
In-Reply-To: <1446504164-21563-2-git-send-email-mathieu.desnoyers@efficios.com>
On Mon, 2 Nov 2015 17:42:43 -0500
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> In order to use ftrace tracers to generate tracepoints without doing
> tracing to its own hardcoded ring buffers, add a ftrace-buffer option
> (default: 1). When set to 0, it disables tracing into the ftrace
> hardcoded buffers.
>
This should be a tracer specific option. And it shouldn't be called
"ftrace-buffer" as that is a very confusing name.
Perhaps I can add an option that will prevent the snapshots as well.
Perhaps an option called "quiet", and a "no_snapshot" one too. I can
create the no snapshot one. But this should be converted to "quiet" and
added as a tracer specific option.
-- Steve
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> CC: Thomas Gleixner <tglx@linutronix.de>
> CC: Steven Rostedt <rostedt@goodmis.org>
> CC: Ingo Molnar <mingo@redhat.com>
> CC: Peter Zijlstra <peterz@infradead.org>
> ---
> kernel/trace/trace.c | 4 +++-
> kernel/trace/trace.h | 1 +
> kernel/trace/trace_irqsoff.c | 19 +++++++++++--------
> 3 files changed, 15 insertions(+), 9 deletions(-)
next prev parent reply other threads:[~2015-11-23 21:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 22:42 [PATCH 1/3] Tracepoint: fix documentation of RCU lockdep checks Mathieu Desnoyers
2015-11-02 22:42 ` [PATCH 2/3] ftrace: add ftrace-buffer option Mathieu Desnoyers
2015-11-02 22:56 ` Steven Rostedt
2015-11-02 23:01 ` Mathieu Desnoyers
2015-11-02 23:12 ` Steven Rostedt
2015-11-23 21:46 ` Steven Rostedt [this message]
2015-11-24 12:50 ` Mathieu Desnoyers
2015-11-02 22:42 ` [PATCH v2 3/3] trace: emit tracepoint in preempt and irqs off tracer Mathieu Desnoyers
2015-11-18 14:39 ` Mathieu Desnoyers
2015-11-18 14:47 ` Steven Rostedt
2015-11-18 15:08 ` Thomas Gleixner
2015-11-02 22:51 ` [PATCH 1/3] Tracepoint: fix documentation of RCU lockdep checks Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123164643.04f8601d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®