From: Tejun Heo <tj@kernel.org>
To: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: davem@davemloft.net, pablo@netfilter.org, kaber@trash.net,
kadlec@blackhole.kfki.hu, daniel@iogearbox.net,
nhorman@tuxdriver.co, lizefan@huawei.com, hannes@cmpxchg.org,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com, ninasc@fb.com
Subject: Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup
Date: Mon, 23 Nov 2015 14:58:04 -0500 [thread overview]
Message-ID: <20151123195804.GB19072@mtj.duckdns.org> (raw)
In-Reply-To: <20151123155346.GE3049@mtj.duckdns.org>
Hello,
On Mon, Nov 23, 2015 at 10:53:46AM -0500, Tejun Heo wrote:
> > [ 11.594536] ------------[ cut here ]------------
> > [ 11.595274] WARNING: CPU: 1 PID: 1 at kernel/cgroup_pids.c:97 pids_cancel.constprop.6+0x31/0x40()
> > [ 11.595958] Modules linked in:
> > [ 11.596199] CPU: 1 PID: 1 Comm: systemd Not tainted 4.4.0-rc1+ #196
> > [ 11.596689] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.8.2-0-g33fbe13 by qemu-project.org 04/01/2014
> > [ 11.597632] ffffffff81f66d8b ffff88007c04bb90 ffffffff8155ccdc 0000000000000000
> > [ 11.598234] ffff88007c04bbc8 ffffffff810de202 ffff8800793dda00 ffff88007a096800
> > [ 11.598877] ffff88007c04bc80 ffff88007a6b6200 0000000000000001 ffff88007c04bbd8
> > [ 11.599547] Call Trace:
> > [ 11.599784] [<ffffffff8155ccdc>] dump_stack+0x4e/0x82
> > [ 11.600197] [<ffffffff810de202>] warn_slowpath_common+0x82/0xc0
> > [ 11.600705] [<ffffffff810de2fa>] warn_slowpath_null+0x1a/0x20
> > [ 11.601208] [<ffffffff8118e261>] pids_cancel.constprop.6+0x31/0x40
> > [ 11.601764] [<ffffffff8118e32d>] pids_can_attach+0x6d/0xf0
>
> Yeah, this is a known problem regarding css's lifetime. Working on
> it. The earlier dump, I think, is likely to have been caused by the
> same issue.
Just posted the fix for this issue. Can you please verify the fix?
http://lkml.kernel.org/g/20151123195541.GA19072@mtj.duckdns.org
Thanks a lot!
--
tejun
next prev parent reply other threads:[~2015-11-23 19:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 16:13 Tejun Heo
2015-11-21 16:13 ` [PATCH 1/9] cgroup: record ancestor IDs and reimplement cgroup_is_descendant() using it Tejun Heo
2015-11-21 16:13 ` [PATCH 2/9] kernfs: implement kernfs_walk_and_get() Tejun Heo
2015-11-21 16:13 ` [PATCH 3/9] cgroup: implement cgroup_get_from_path() and expose cgroup_put() Tejun Heo
2015-11-21 16:13 ` [PATCH 4/9] cgroups: Allow dynamically changing net_classid Tejun Heo
2015-11-21 16:13 ` [PATCH 5/9] netprio_cgroup: limit the maximum css->id to USHRT_MAX Tejun Heo
2015-11-21 16:13 ` [PATCH 6/9] net: wrap sock->sk_cgrp_prioidx and ->sk_classid inside a struct Tejun Heo
2015-11-21 16:13 ` [PATCH 7/9] sock, cgroup: add sock->sk_cgroup Tejun Heo
2015-11-23 13:02 ` Daniel Wagner
2015-11-23 15:48 ` Tejun Heo
2015-11-23 15:53 ` Daniel Wagner
2015-11-21 16:14 ` [PATCH 8/9] netfilter: prepare xt_cgroup for multi revisions Tejun Heo
2015-11-23 12:44 ` Daniel Wagner
2015-11-21 16:14 ` [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo
2015-11-21 16:56 ` Florian Westphal
2015-11-21 17:04 ` Tejun Heo
2015-11-21 18:54 ` Florian Westphal
2015-11-21 20:26 ` Jan Engelhardt
2015-11-23 13:43 ` Daniel Borkmann
2015-11-23 13:51 ` Daniel Borkmann
2015-11-23 15:40 ` Tejun Heo
2015-11-23 17:35 ` David Laight
2015-11-23 17:55 ` Jan Engelhardt
2015-11-23 12:43 ` Daniel Wagner
2015-11-23 15:41 ` Tejun Heo
2015-11-21 16:17 ` [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Tejun Heo
2015-11-21 16:18 ` [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions Tejun Heo
2015-11-21 16:19 ` [PATCH 2/2 iptables] libxt_cgroup: add support for cgroup2 path matching Tejun Heo
2015-11-22 20:31 ` [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions Pablo Neira Ayuso
2015-11-22 20:34 ` Pablo Neira Ayuso
2015-11-23 7:11 ` [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Daniel Wagner
2015-11-23 8:54 ` Daniel Wagner
2015-11-23 15:53 ` Tejun Heo
2015-11-23 15:57 ` Daniel Wagner
2015-11-23 19:58 ` Tejun Heo [this message]
2015-11-23 20:45 ` David Miller
2015-11-23 20:54 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123195804.GB19072@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hannes@cmpxchg.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nhorman@tuxdriver.co \
--cc=ninasc@fb.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®