From: Jan Engelhardt <jengelh@inai.de>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "'Florian Westphal'" <fw@strlen.de>, Tejun Heo <tj@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"pablo@netfilter.org" <pablo@netfilter.org>,
"kaber@trash.net" <kaber@trash.net>,
"kadlec@blackhole.kfki.hu" <kadlec@blackhole.kfki.hu>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"daniel.wagner@bmw-carit.de" <daniel.wagner@bmw-carit.de>,
"nhorman@tuxdriver.co" <nhorman@tuxdriver.co>,
"lizefan@huawei.com" <lizefan@huawei.com>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"coreteam@netfilter.org" <coreteam@netfilter.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-team@fb.com" <kernel-team@fb.com>,
"ninasc@fb.com" <ninasc@fb.com>,
Neil Horman <nhorman@tuxdriver.com>
Subject: RE: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match
Date: Mon, 23 Nov 2015 18:55:55 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.20.1511231853260.25633@nerf40.vanv.qr> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CBDA8E2@AcuExch.aculab.com>
On Monday 2015-11-23 18:35, David Laight wrote:
>From: Florian Westphal
>> Sent: 21 November 2015 16:56
>> > +struct xt_cgroup_info_v1 {
>> > + char path[PATH_MAX];
>> > + __u32 classid;
>> > +
>> > + /* kernel internal data */
>> > + void *priv __attribute__((aligned(8)));
>> > +};
>>
>> Ahem. Am I reading this right? This struct is > 4k in size?
>> If so -- Ugh. Does sizeof(path) really have to be PATH_MAX?
>
>I've not looked at the use, but could you put 'char path[];'
>as the last member an require any allocations to be long enough
>to contain the actual path?
Oh, smart :) Yeah, ebt_among does something like that.
(.matchsize = -1, hint)
Except that the "priv" pointer seems to be ruining the fun here -
kernel vars have to be last, which collides with the requirements
for []-type members.
next prev parent reply other threads:[~2015-11-23 17:55 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 16:13 [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Tejun Heo
2015-11-21 16:13 ` [PATCH 1/9] cgroup: record ancestor IDs and reimplement cgroup_is_descendant() using it Tejun Heo
2015-11-21 16:13 ` [PATCH 2/9] kernfs: implement kernfs_walk_and_get() Tejun Heo
2015-11-21 16:13 ` [PATCH 3/9] cgroup: implement cgroup_get_from_path() and expose cgroup_put() Tejun Heo
2015-11-21 16:13 ` [PATCH 4/9] cgroups: Allow dynamically changing net_classid Tejun Heo
2015-11-21 16:13 ` [PATCH 5/9] netprio_cgroup: limit the maximum css->id to USHRT_MAX Tejun Heo
2015-11-21 16:13 ` [PATCH 6/9] net: wrap sock->sk_cgrp_prioidx and ->sk_classid inside a struct Tejun Heo
2015-11-21 16:13 ` [PATCH 7/9] sock, cgroup: add sock->sk_cgroup Tejun Heo
2015-11-23 13:02 ` Daniel Wagner
2015-11-23 15:48 ` Tejun Heo
2015-11-23 15:53 ` Daniel Wagner
2015-11-21 16:14 ` [PATCH 8/9] netfilter: prepare xt_cgroup for multi revisions Tejun Heo
2015-11-23 12:44 ` Daniel Wagner
2015-11-21 16:14 ` [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo
2015-11-21 16:56 ` Florian Westphal
2015-11-21 17:04 ` Tejun Heo
2015-11-21 18:54 ` Florian Westphal
2015-11-21 20:26 ` Jan Engelhardt
2015-11-23 13:43 ` Daniel Borkmann
2015-11-23 13:51 ` Daniel Borkmann
2015-11-23 15:40 ` Tejun Heo
2015-11-23 17:35 ` David Laight
2015-11-23 17:55 ` Jan Engelhardt [this message]
2015-11-23 12:43 ` Daniel Wagner
2015-11-23 15:41 ` Tejun Heo
2015-11-21 16:17 ` [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Tejun Heo
2015-11-21 16:18 ` [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions Tejun Heo
2015-11-21 16:19 ` [PATCH 2/2 iptables] libxt_cgroup: add support for cgroup2 path matching Tejun Heo
2015-11-22 20:31 ` [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions Pablo Neira Ayuso
2015-11-22 20:34 ` Pablo Neira Ayuso
2015-11-23 7:11 ` [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Daniel Wagner
2015-11-23 8:54 ` Daniel Wagner
2015-11-23 15:53 ` Tejun Heo
2015-11-23 15:57 ` Daniel Wagner
2015-11-23 19:58 ` Tejun Heo
2015-11-23 20:45 ` David Miller
2015-11-23 20:54 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1511231853260.25633@nerf40.vanv.qr \
--to=jengelh@inai.de \
--cc=David.Laight@ACULAB.COM \
--cc=cgroups@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=hannes@cmpxchg.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nhorman@tuxdriver.co \
--cc=nhorman@tuxdriver.com \
--cc=ninasc@fb.com \
--cc=pablo@netfilter.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®