mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH 1/2] ftrace: Add separate handler for ftrace:function event
Date: Wed, 25 Nov 2015 12:42:21 -0500	[thread overview]
Message-ID: <20151125124221.281d6f3d@gandalf.local.home> (raw)
In-Reply-To: <20151125171243.GA2214@krava.brq.redhat.com>

On Wed, 25 Nov 2015 18:12:43 +0100
Jiri Olsa <jolsa@redhat.com> wrote:

> > Yeah, I'm trying to figure out the paths here. I would love to remove
> > the control_ops as that complicates the function tracing code a bit
> > more than I would like it to be.  
> 
> perf is using the control interface to enable and disable function
> tracing any time the process (and its events) is scheduled in/out
> 
> sched_in(event)  -> ftrace_function_local_enable(&event->ftrace_ops)
> sched_out(event) -> ftrace_function_local_disable(&event->ftrace_ops)

OK, I think we can merge the control list to the normal list and have
something like:

 (!op->disabled || !ftrace_function_local_disabled(op))

We can also keep the control flag for the ops, and have:

	!(op->flags & FTRACE_OPS_FL_CONTROL) || rcu_is_watching()

test too, and use the ftrace ops list code.

-- Steve

      reply	other threads:[~2015-11-25 17:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 15:45 Jiri Olsa
2015-11-25 15:45 ` [PATCH 2/2] ftrace: Check sample types only for sampling events Jiri Olsa
2015-11-25 16:19 ` [PATCH 1/2] ftrace: Add separate handler for ftrace:function event Steven Rostedt
2015-11-25 16:50   ` Jiri Olsa
2015-11-25 17:02     ` Steven Rostedt
2015-11-25 17:12       ` Jiri Olsa
2015-11-25 17:42         ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151125124221.281d6f3d@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®