mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>,
	linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH 1/2] zram: pass gfp from zcomp frontend to backend
Date: Mon, 30 Nov 2015 16:10:04 -0800	[thread overview]
Message-ID: <20151130161004.171a80a7f618a2c55ff885c6@linux-foundation.org> (raw)
In-Reply-To: <1448598194-24754-2-git-send-email-sergey.senozhatsky@gmail.com>

On Fri, 27 Nov 2015 13:23:13 +0900 Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:

> From: Minchan Kim <minchan@kernel.org>
> 
> Each zcomp backend uses own gfp flag but it's pointless
> because the context they could be called is driven by upper
> layer(ie, zcomp frontend). As well, zcomp frondend could
> call them in different context. One context(ie, zram init part)
> is it should be better to make sure successful allocation
> other context(ie, further stream allocation part for accelarating
> I/O speed) is just optional so let's pass gfp down from driver
> (ie, zcomp frontend) like normal MM convention.
> 
> [sergey: add missing __vmalloc zero and highmem gfps]
> Signed-off-by: Minchan Kim <minchan@kernel.org>
> Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

I changed this to signed-off-by:you.  Documentation/SubmittingPatches
section 11 explains why ;)

(Hm, rule (c) is recursive.  Nice!)

  reply	other threads:[~2015-12-01  0:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27  4:23 [PATCH 0/2] zram: cleanup stream's ->private allocation code Sergey Senozhatsky
2015-11-27  4:23 ` [PATCH 1/2] zram: pass gfp from zcomp frontend to backend Sergey Senozhatsky
2015-12-01  0:10   ` Andrew Morton [this message]
2015-12-01  0:44     ` Sergey Senozhatsky
2015-11-27  4:23 ` [PATCH 2/2] zram/zcomp: do not zero out zcomp private pages Sergey Senozhatsky
2015-11-30  7:14   ` Minchan Kim
  -- strict thread matches above, loose matches on Subject: below --
2015-11-25  5:51 [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend Minchan Kim
2015-11-25 12:50 ` [PATCH 1/2] " Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151130161004.171a80a7f618a2c55ff885c6@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®