From: Andrew Morton <akpm@linux-foundation.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Tejun Heo <tj@kernel.org>, Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/13] lib/vsprintf.c: expand field_width to 24 bits
Date: Tue, 1 Dec 2015 15:38:12 -0800 [thread overview]
Message-ID: <20151201153812.8312aae7ff2b9b20d3fe6c4e@linux-foundation.org> (raw)
In-Reply-To: <1445373013-20207-5-git-send-email-linux@rasmusvillemoes.dk>
On Tue, 20 Oct 2015 22:30:04 +0200 Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> I didn't find a BUILD_BUG/compiletime_assertion/... which would work
> outside function context, so for now I just open-coded it.
>
It comes up occasionally. It would be better to create one.
> +extern char __check_printf_spec[1-2*(sizeof(struct printf_spec) != 8)];
Maybe something like
/*
* Description goes here
*/
#define BUILD_BUG_ON_STATIC(unique_id, expr) \
typedef char unique_id[1-2*(expr)];
BUILD_BUG_ON_STATIC(__check_printf_spec, sizeof(struct printf_spec) != 8);
("static" seems the wrong term, but what is the correct term for
"outside of functions"?)
(I hope this patchset is still up-to-date)
next prev parent reply other threads:[~2015-12-01 23:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1445373013-20207-1-git-send-email-linux@rasmusvillemoes.dk>
2015-10-20 20:30 ` [PATCH 01/13] lib/vsprintf.c: pull out padding code from dentry_name() Rasmus Villemoes
2015-10-20 20:30 ` [PATCH 02/13] lib/vsprintf.c: move string() below widen_string() Rasmus Villemoes
2015-10-20 20:30 ` [PATCH 03/13] lib/vsprintf.c: eliminate potential race in string() Rasmus Villemoes
2015-10-20 20:30 ` [PATCH 04/13] lib/vsprintf.c: expand field_width to 24 bits Rasmus Villemoes
2015-10-20 23:39 ` kbuild test robot
2015-10-21 8:54 ` Rasmus Villemoes
2015-10-21 8:59 ` [PATCH v2 " Rasmus Villemoes
2015-12-01 23:38 ` Andrew Morton [this message]
2015-12-13 0:46 ` [PATCH " Andy Shevchenko
2015-10-20 20:30 ` [PATCH 05/13] lib/vsprintf.c: help gcc make number() smaller Rasmus Villemoes
2015-10-20 20:30 ` [PATCH 06/13] lib/vsprintf.c: warn about too large precisions and field widths Rasmus Villemoes
2015-10-20 20:30 ` [PATCH 07/13] lib/test_printf.c: don't BUG Rasmus Villemoes
2015-10-26 6:39 ` Kees Cook
2015-10-20 20:30 ` [PATCH 08/13] lib/test_printf.c: check for out-of-bound writes Rasmus Villemoes
2015-10-26 6:41 ` Kees Cook
2015-10-20 20:30 ` [PATCH 09/13] lib/test_printf.c: add a few string tests Rasmus Villemoes
2015-10-26 6:43 ` Kees Cook
2015-10-20 20:30 ` [PATCH 10/13] lib/test_printf.c: account for kvasprintf tests Rasmus Villemoes
2015-10-26 6:43 ` Kees Cook
2015-10-20 20:30 ` [PATCH 11/13] lib/test_printf.c: add test for large bitmaps Rasmus Villemoes
2015-10-26 6:45 ` Kees Cook
2015-10-20 20:30 ` [PATCH 12/13] lib/test_printf.c: test dentry printing Rasmus Villemoes
2015-10-20 20:30 ` [PATCH 13/13] lib/kasprintf.c: add sanity check to kvasprintf Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201153812.8312aae7ff2b9b20d3fe6c4e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome