From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
David Sterba <dsterba@suse.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Matt Mackall <mpm@selenic.com>, Chris Mason <clm@fb.com>,
Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH 3/4] x86/cpufeature: Remove unused and seldomly used cpu_has_xx macros
Date: Sat, 5 Dec 2015 21:03:13 +0100 [thread overview]
Message-ID: <20151205200313.GB18105@pd.tnic> (raw)
In-Reply-To: <alpine.DEB.2.11.1512052058300.3595@nanos>
On Sat, Dec 05, 2015 at 08:59:45PM +0100, Thomas Gleixner wrote:
> On Tue, 1 Dec 2015, Borislav Petkov wrote:
> > -#define cpu_has_ht boot_cpu_has(X86_FEATURE_HT)
>
> tip/arch/x86/include/asm/smp.h: In function ‘cpu_has_ht_siblings’:
> tip/arch/x86/include/asm/smp.h:28:17: error: ‘cpu_has_ht’ undeclared (first use in this function)
> has_siblings = cpu_has_ht && smp_num_siblings > 1;
Yeah, this series needs to go ontop of
ed29210cd6a6 ("x86: Remove unused function cpu_has_ht_siblings()")
which is in tip/x86/cleanups.
BTW, thanks for taking a look, I'll send an updated one removing the
static_cpu_has_safe() calls as you suggested in your other mail.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2015-12-05 20:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 15:00 [PATCH 0/4] x86/cpufeature: Cleanup stuff more Borislav Petkov
2015-12-01 15:00 ` [PATCH 1/4] x86/cpufeature: Move some of the scattered feature bits to x86_capability Borislav Petkov
2015-12-01 15:00 ` [PATCH 2/4] x86/cpufeature: Cleanup get_cpu_cap() Borislav Petkov
2015-12-01 15:00 ` [PATCH 3/4] x86/cpufeature: Remove unused and seldomly used cpu_has_xx macros Borislav Petkov
2015-12-05 18:50 ` Thomas Gleixner
2015-12-06 14:27 ` [PATCH -v1.1 " Borislav Petkov
2015-12-05 19:59 ` [PATCH " Thomas Gleixner
2015-12-05 20:03 ` Borislav Petkov [this message]
2015-12-01 15:00 ` [PATCH 4/4] x86/cpu: Provide a config option to disable static_cpu_has Borislav Petkov
2015-12-01 16:24 ` Josh Triplett
2015-12-01 16:57 ` Borislav Petkov
2015-12-07 9:39 [PATCH 0/4] x86/cpufeature: Cleanup, p1 Borislav Petkov
2015-12-07 9:39 ` [PATCH 3/4] x86/cpufeature: Remove unused and seldomly used cpu_has_xx macros Borislav Petkov
2015-12-07 9:45 ` Ingo Molnar
2015-12-07 9:54 ` Borislav Petkov
2015-12-07 13:36 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151205200313.GB18105@pd.tnic \
--to=bp@alien8.de \
--cc=a.p.zijlstra@chello.nl \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=herbert@gondor.apana.org.au \
--cc=jbacik@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®