From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Wilck, Martin" <martin.wilck@ts.fujitsu.com>
Cc: "Jason Gunthorpe" <jgunthorpe@obsidianresearch.com>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter
Date: Mon, 7 Dec 2015 10:56:26 +0200 [thread overview]
Message-ID: <20151207085626.GA15567@intel.com> (raw)
In-Reply-To: <C5A28EF7B98F574C85C70238C8E9ECC04E682BF175@ABGEX74E.FSC.NET>
On Mon, Dec 07, 2015 at 09:06:50AM +0100, Wilck, Martin wrote:
> > > I'm a bit confused about the discussion because Martin replied that
> > > tpm_tis used to get the address range before applying this series.
> > >
> > > And pnp_driver in the backend for TPM 1.x devices grabs the address
> > > range from DSDT.
> >
> > You can completely ignore this question. I saw Martins reply with a fix for
> > "tpm_tis: Use devm_ioremap_resource" that you should squash into that
> > change. So it's proved that TPM ACPI device objects do not always have a
> > memory resource. Good.
>
> Repeat, the memory resource DOES exist on my system. Not sure what proof
> you saw there.
Ok, lets go this through.
I deduced this from two facts:
* It used to have memory resource as conditional and as a fallback use
fixed value.
* Your workaround reverted the situation to this.
Did I understand something incorrectly?
/Jarkko
next prev parent reply other threads:[~2015-12-07 8:56 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 18:58 Jason Gunthorpe
2015-12-01 18:58 ` [PATCH v2 1/3] tpm_tis: Disable interrupt auto probing on a per-device basis Jason Gunthorpe
2015-12-01 19:19 ` Uwe Kleine-König
2015-12-01 19:36 ` Jason Gunthorpe
2015-12-01 18:58 ` [PATCH v2 2/3] tpm_tis: Use devm_ioremap_resource Jason Gunthorpe
2015-12-01 19:22 ` Uwe Kleine-König
2015-12-01 19:44 ` Jason Gunthorpe
2015-12-01 19:52 ` Uwe Kleine-König
2015-12-01 20:46 ` Jason Gunthorpe
2015-12-01 18:58 ` [PATCH v2 3/3] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe
2015-12-01 19:33 ` Uwe Kleine-König
2015-12-01 19:51 ` Jason Gunthorpe
2015-12-01 21:14 ` [PATCH v2 0/3] tpm_tis: Clean up force " Jarkko Sakkinen
2015-12-01 21:33 ` Jarkko Sakkinen
2015-12-01 22:22 ` Jason Gunthorpe
2015-12-02 1:15 ` Peter Huewe
2015-12-02 8:14 ` Jarkko Sakkinen
2015-12-02 9:02 ` Peter Huewe
2015-12-02 8:11 ` Jarkko Sakkinen
2015-12-02 8:21 ` Uwe Kleine-König
2015-12-02 16:53 ` Greg Kroah-Hartman
2015-12-02 16:59 ` Uwe Kleine-König
2015-12-03 8:51 ` [PATCH v3] base/platform: fix binding for drivers without probe callback martin.wilck
2015-12-03 9:00 ` Uwe Kleine-König
2015-12-03 9:34 ` [tpmdd-devel] " Jarkko Sakkinen
2015-12-02 18:27 ` [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jason Gunthorpe
2015-12-02 19:11 ` [tpmdd-devel] " Jason Gunthorpe
2015-12-03 6:00 ` Jarkko Sakkinen
2015-12-03 18:19 ` Jason Gunthorpe
2015-12-06 4:02 ` Jarkko Sakkinen
2015-12-06 4:15 ` Jarkko Sakkinen
2015-12-06 4:20 ` Jarkko Sakkinen
2015-12-07 6:15 ` Jason Gunthorpe
2015-12-07 8:06 ` Wilck, Martin
2015-12-07 8:56 ` Jarkko Sakkinen [this message]
2015-12-07 9:52 ` Wilck, Martin
2015-12-07 10:16 ` Jarkko Sakkinen
2015-12-03 8:30 ` Wilck, Martin
2015-12-03 17:00 ` Jason Gunthorpe
2015-12-04 8:39 ` Wilck, Martin
2015-12-04 9:10 ` Wilck, Martin
2015-12-04 18:09 ` Jason Gunthorpe
2015-12-07 9:59 ` Wilck, Martin
2015-12-07 17:35 ` Jason Gunthorpe
2015-12-03 5:58 ` Jarkko Sakkinen
2015-12-02 12:34 ` Wilck, Martin
2015-12-02 18:11 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207085626.GA15567@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.wilck@ts.fujitsu.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome