mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Wilck, Martin" <martin.wilck@ts.fujitsu.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	"tpmdd-devel@lists.sourceforge.net" 
	<tpmdd-devel@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>
Subject: Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter
Date: Fri, 4 Dec 2015 09:39:14 +0100	[thread overview]
Message-ID: <C5A28EF7B98F574C85C70238C8E9ECC04E682BF16C@ABGEX74E.FSC.NET> (raw)
In-Reply-To: <20151203170041.GA32175@obsidianresearch.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1554 bytes --]




On Do, 2015-12-03 at 10:00 -0700, Jason Gunthorpe wrote:
> On Thu, Dec 03, 2015 at 09:30:30AM +0100, Wilck, Martin wrote:
> > On Mi, 2015-12-02 at 12:11 -0700, Jason Gunthorpe wrote:
> > 
> > > > What is the address tpm_tis should be using? I see two things, it
> > > > either uses the x86 default address or it expects the ACPI to have a
> > > > MEM resource. AFAIK ACPI should never rely on hard wired addresses, so
> > > > I removed that code in this series. Perhaps tpm_tis should be using
> > > > control_area_pa ? Will ACPI ever present a struct resource? (if yes,
> > > > why isn't tpm_crb using one?)
> > > 
> > > Is then still a problem. On Martin's system the MSFT0101 device does
> > > not have a struct resource attached to it. Does any system, or is this
> > > just dead code?
> > 
> > ACPI defines a mem resource corresponding to the standard TIS memory
> > area on my system, and it used to be detected fine with Jarkko's patch.
> > Somehow your latest changes broke it, not sure why.
> 
> Are you certain? Based on what you sent me, that output is only
> possible if there is no mem resource.

Yes, I am certain. I checked the DSDT, and I put a debug statement right
after the resource detection in tpm_tis.

Martin


> With the prior arrangement no mem resource means the x86 default
> address is used, which is the only way I can see how your system
> works.



> 
> Jason
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2015-12-04  8:39 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 18:58 Jason Gunthorpe
2015-12-01 18:58 ` [PATCH v2 1/3] tpm_tis: Disable interrupt auto probing on a per-device basis Jason Gunthorpe
2015-12-01 19:19   ` Uwe Kleine-König
2015-12-01 19:36     ` Jason Gunthorpe
2015-12-01 18:58 ` [PATCH v2 2/3] tpm_tis: Use devm_ioremap_resource Jason Gunthorpe
2015-12-01 19:22   ` Uwe Kleine-König
2015-12-01 19:44     ` Jason Gunthorpe
2015-12-01 19:52       ` Uwe Kleine-König
2015-12-01 20:46         ` Jason Gunthorpe
2015-12-01 18:58 ` [PATCH v2 3/3] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe
2015-12-01 19:33   ` Uwe Kleine-König
2015-12-01 19:51     ` Jason Gunthorpe
2015-12-01 21:14 ` [PATCH v2 0/3] tpm_tis: Clean up force " Jarkko Sakkinen
2015-12-01 21:33 ` Jarkko Sakkinen
2015-12-01 22:22   ` Jason Gunthorpe
2015-12-02  1:15     ` Peter Huewe
2015-12-02  8:14       ` Jarkko Sakkinen
2015-12-02  9:02         ` Peter Huewe
2015-12-02  8:11     ` Jarkko Sakkinen
2015-12-02  8:21       ` Uwe Kleine-König
2015-12-02 16:53         ` Greg Kroah-Hartman
2015-12-02 16:59           ` Uwe Kleine-König
2015-12-03  8:51           ` [PATCH v3] base/platform: fix binding for drivers without probe callback martin.wilck
2015-12-03  9:00             ` Uwe Kleine-König
2015-12-03  9:34             ` [tpmdd-devel] " Jarkko Sakkinen
2015-12-02 18:27   ` [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jason Gunthorpe
2015-12-02 19:11     ` [tpmdd-devel] " Jason Gunthorpe
2015-12-03  6:00       ` Jarkko Sakkinen
2015-12-03 18:19         ` Jason Gunthorpe
2015-12-06  4:02           ` Jarkko Sakkinen
2015-12-06  4:15             ` Jarkko Sakkinen
2015-12-06  4:20               ` Jarkko Sakkinen
2015-12-07  6:15               ` Jason Gunthorpe
2015-12-07  8:06               ` Wilck, Martin
2015-12-07  8:56                 ` Jarkko Sakkinen
2015-12-07  9:52                   ` Wilck, Martin
2015-12-07 10:16                     ` Jarkko Sakkinen
2015-12-03  8:30       ` Wilck, Martin
2015-12-03 17:00         ` Jason Gunthorpe
2015-12-04  8:39           ` Wilck, Martin [this message]
2015-12-04  9:10           ` Wilck, Martin
2015-12-04 18:09             ` Jason Gunthorpe
2015-12-07  9:59               ` Wilck, Martin
2015-12-07 17:35                 ` Jason Gunthorpe
2015-12-03  5:58     ` Jarkko Sakkinen
2015-12-02 12:34 ` Wilck, Martin
2015-12-02 18:11   ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C5A28EF7B98F574C85C70238C8E9ECC04E682BF16C@ABGEX74E.FSC.NET \
    --to=martin.wilck@ts.fujitsu.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®