mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Noam Camus <noamc@ezchip.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"jslaby@suse.com" <jslaby@suse.com>,
	"peter@hurleysoftware.com" <peter@hurleysoftware.com>,
	"fransklaver@gmail.com" <fransklaver@gmail.com>,
	"Alexey.Brodkin@synopsys.com" <Alexey.Brodkin@synopsys.com>,
	"vgupta@synopsys.com" <vgupta@synopsys.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses
Date: Fri, 11 Dec 2015 10:37:05 +0200	[thread overview]
Message-ID: <20151211083705.GF4884@kuha.fi.intel.com> (raw)
In-Reply-To: <45xw80lci7vs893wq469l1b0.1449765214447@com.syntomo.email>

Hi Noam,

On Thu, Dec 10, 2015 at 04:33:39PM +0000, Noam Camus wrote:
> Please see
> https://lkml.org/lkml/2015/8/3/806
> Why I added private accessors.

Greg is not saying anything about the iotype checking there? Looks
more like confusion about what exactly is that patch trying to
achieve. I think Greg just thought you moved the writel call from
the beginning of the function to be called later inside the "else"
condition.

You need to start your series with a patch where you just separate the
lcr checking to its own function and follow that with patches where
you introduce the big-endian support. I think this is also what Andy
told you. Use the diff I gave you.

One more thing that I forgot to comment before:

s/dw8250_check_LCR/dw8250_check_lcr/


Thanks,

-- 
heikki

       reply	other threads:[~2015-12-11  8:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <45xw80lci7vs893wq469l1b0.1449765214447@com.syntomo.email>
2015-12-11  8:37 ` Heikki Krogerus [this message]
2015-10-06  6:39 [v6] *** 8250_dw *** Noam Camus
2015-10-18  9:01 ` [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses Noam Camus
2015-12-09 13:19   ` Heikki Krogerus
2015-12-09 13:21     ` Heikki Krogerus
2015-12-10  7:26     ` Noam Camus
2015-12-10  9:31       ` Heikki Krogerus
2015-12-10 10:33         ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151211083705.GF4884@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=fransklaver@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=noamc@ezchip.com \
    --cc=peter@hurleysoftware.com \
    --cc=vgupta@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome