mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Chris Mason <clm@fb.com>, Dave Jones <dsj@fb.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Jon Christopherson <jon@jons.org>, NeilBrown <neilb@suse.de>,
	Ingo Molnar <mingo@kernel.org>,
	David Howells <dhowells@redhat.com>,
	Steven Whitehouse <swhiteho@redhat.com>
Subject: Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR
Date: Sun, 13 Dec 2015 10:50:01 +0100	[thread overview]
Message-ID: <20151213095001.GI6357@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CA+55aFx33yx-qevdj4oXU+d=7Cz8U0bhJCNpqJmwuJfM3O2LyQ@mail.gmail.com>

On Sat, Dec 12, 2015 at 11:41:26AM -0800, Linus Torvalds wrote:
> It looks like PeterZ's pending patch should fix this, by passing in
> the proper TASK_UNINTERRUPTIBLE to the bit_wait_io function, and going
> back to signal_pending_state(). PeterZ, did I follow the history of
> this correctly?

Yes. I made a right mess of things with my 'fix'.

  parent reply	other threads:[~2015-12-13  9:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-12 16:23 Chris Mason
2015-12-12 18:33 ` Linus Torvalds
2015-12-12 19:41   ` Linus Torvalds
2015-12-13  0:07     ` Chris Mason
2015-12-14 18:33       ` Dave Jones
2015-12-14 20:01         ` Chris Mason
2015-12-14 23:59         ` Chris Mason
2015-12-13  9:50     ` Peter Zijlstra [this message]
2015-12-13 15:55       ` Chris Mason
2015-12-13 20:51       ` Linus Torvalds
2015-12-13 21:12         ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151213095001.GI6357@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=clm@fb.com \
    --cc=dhowells@redhat.com \
    --cc=dsj@fb.com \
    --cc=jon@jons.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=neilb@suse.de \
    --cc=swhiteho@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome