From: David Miller <davem@davemloft.net>
To: haiyangz@microsoft.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
kys@microsoft.com, olaf@aepfle.de, linux-kernel@vger.kernel.org,
driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH net-next] hv_netvsc: Use simple parser for IPv4 and v6 headers
Date: Wed, 16 Dec 2015 18:23:10 -0500 (EST) [thread overview]
Message-ID: <20151216.182310.1967561459941374668.davem@davemloft.net> (raw)
In-Reply-To: <BN1PR0301MB0770A1CB185D1AB82D5F9E44CAEF0@BN1PR0301MB0770.namprd03.prod.outlook.com>
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Wed, 16 Dec 2015 19:20:44 +0000
> In our test, we have bisected and found the following patch introduced big
> overhead into skb_flow_dissect_flow_keys(), and caused performance
> regression:
> commit: d34af823
> net: Add VLAN ID to flow_keys
NEVER _EVER_ work around this kind of problem by bypassing the code in
question in your driver.
ALWAYS work to fix the actual problem.
next prev parent reply other threads:[~2015-12-16 23:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 18:03 Haiyang Zhang
2015-12-16 17:08 ` Eric Dumazet
2015-12-16 19:20 ` Haiyang Zhang
2015-12-16 21:19 ` Eric Dumazet
2015-12-16 23:23 ` David Miller [this message]
2015-12-16 18:34 ` Sergei Shtylyov
2015-12-16 18:45 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151216.182310.1967561459941374668.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=eric.dumazet@gmail.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®