From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, vince@deater.net,
eranian@google.com, johannes@sipsolutions.net,
Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH 2/7] perf: Generalize task_function_call()ers
Date: Thu, 17 Dec 2015 16:07:32 +0100 [thread overview]
Message-ID: <20151217150732.GG6344@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <87k2odb19x.fsf@ashishki-desk.ger.corp.intel.com>
On Thu, Dec 17, 2015 at 04:25:14PM +0200, Alexander Shishkin wrote:
> That aside, why I brought it up in the first place is because the two
> functions are asymmetric: one is called with irqs disabled and the
> other -- with ctx::lock held (and not because I'm into bikeshedding or
> anything like that). Looking at the pair of them sets off my "that's not
> right" trigger and sends me to the event_function_call()
> implementation. So in that sense, prepending an extra underscore kind of
> made sense. Maybe __perf_remove_from_context_{on,off}()?
You are quite right, and I think I've found more problems because of
this. Let me prod at this some more.
next prev parent reply other threads:[~2015-12-17 15:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 10:32 [PATCH 0/7] perf: Untangle aux refcounting Alexander Shishkin
2015-12-03 10:32 ` [PATCH 1/7] perf: Refuse to begin aux transaction after aux_mmap_count drops Alexander Shishkin
2015-12-03 10:32 ` [PATCH 2/7] perf: Generalize task_function_call()ers Alexander Shishkin
2015-12-03 17:34 ` Peter Zijlstra
2015-12-08 16:42 ` Alexander Shishkin
2015-12-08 16:57 ` Peter Zijlstra
2015-12-17 13:40 ` Peter Zijlstra
2015-12-17 14:25 ` Alexander Shishkin
2015-12-17 15:07 ` Peter Zijlstra [this message]
2015-12-18 9:01 ` Peter Zijlstra
2015-12-18 15:07 ` Alexander Shishkin
2015-12-18 16:47 ` Peter Zijlstra
2015-12-18 17:41 ` Alexander Shishkin
2015-12-21 14:39 ` Alexander Shishkin
2016-01-11 10:44 ` Alexander Shishkin
2015-12-03 10:32 ` [PATCH 3/7] perf: Add a helper to stop running events Alexander Shishkin
2015-12-03 10:32 ` [PATCH 4/7] perf: Free aux pages in unmap path Alexander Shishkin
2015-12-04 17:02 ` Peter Zijlstra
2015-12-04 22:17 ` Peter Zijlstra
2015-12-07 16:16 ` Peter Zijlstra
2015-12-09 9:57 ` Alexander Shishkin
2015-12-09 10:56 ` Peter Zijlstra
2015-12-10 11:20 ` Alexander Shishkin
2015-12-10 12:58 ` Alexander Shishkin
2015-12-03 10:32 ` [PATCH 5/7] perf: Document aux api usage Alexander Shishkin
2015-12-03 20:36 ` Mathieu Poirier
2015-12-03 10:32 ` [PATCH 6/7] perf/x86/intel/pt: Move transaction start/stop to pmu start/stop callbacks Alexander Shishkin
2015-12-03 10:32 ` [PATCH 7/7] perf/x86/intel/bts: Move transaction start/stop to " Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217150732.GG6344@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@infradead.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome