From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>,
"; linux-crypto" <linux-crypto@vger.kernel.org>,
"megha.dey" <megha.dey@intel.com>
Subject: Re: ahash alg that does not implement import/export failed to register
Date: Sat, 19 Dec 2015 10:33:08 +0800 [thread overview]
Message-ID: <20151219023308.GA27731@gondor.apana.org.au> (raw)
In-Reply-To: <1450488694.30844.11.camel@schen9-desk2.jf.intel.com>
On Fri, Dec 18, 2015 at 05:31:34PM -0800, Tim Chen wrote:
> Herbert,
>
> There are some ahash algorithms like x86's sha1-mb and
> ghash that failed to register because of the newly added
> check of non-zero statesize from commit 8996eafd. But
> since there are algorithms that do not implement an import or
> export, there is no state required for them. Wonder if the check
> should be modified to something like:
No import and export are required by algif_hash so they must be
implemented.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-12-19 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 1:31 Tim Chen
2015-12-19 2:33 ` Herbert Xu [this message]
[not found] ` <568E7AFB.8080905@amd.com>
2016-01-08 9:54 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151219023308.GA27731@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=megha.dey@intel.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®