mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] staging: lustre: This patch fixes the following sparse warning:
@ 2015-12-11  8:08 Jandy Gou
  2015-12-21 23:45 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Jandy Gou @ 2015-12-11  8:08 UTC (permalink / raw)
  To: oleg.drokin
  Cc: andreas.dilger, gregkh, mike.rapoport, jinshan.xiong, yawei.niu,
	lustre-devel, devel, linux-kernel, Jandy Gou

drivers/staging/lustre/lustre/osc/osc_cache.c:622:19: warning: symbol
'osc_extent_find' was not declared. Should it be static?
drivers/staging/lustre/lustre/osc/osc_cache.c:1423:6: warning: symbol
'osc_unreserve_grant' was not declared. Should it be static?

Signed-off-by: Jandy Gou <qingsong.gou@ck-telecom.com>
---
 drivers/staging/lustre/lustre/osc/osc_cache.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/osc/osc_cache.c b/drivers/staging/lustre/lustre/osc/osc_cache.c
index b1d1a87f..62cfca6 100644
--- a/drivers/staging/lustre/lustre/osc/osc_cache.c
+++ b/drivers/staging/lustre/lustre/osc/osc_cache.c
@@ -619,7 +619,7 @@ static inline int overlapped(struct osc_extent *ex1, struct osc_extent *ex2)
  * Find or create an extent which includes @index, core function to manage
  * extent tree.
  */
-struct osc_extent *osc_extent_find(const struct lu_env *env,
+static struct osc_extent *osc_extent_find(const struct lu_env *env,
 				   struct osc_object *obj, pgoff_t index,
 				   int *grants)
 
@@ -1420,7 +1420,7 @@ static void __osc_unreserve_grant(struct client_obd *cli,
 	}
 }
 
-void osc_unreserve_grant(struct client_obd *cli,
+static void osc_unreserve_grant(struct client_obd *cli,
 			 unsigned int reserved, unsigned int unused)
 {
 	client_obd_list_lock(&cli->cl_loi_list_lock);
-- 
1.9.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: lustre: This patch fixes the following sparse warning:
  2015-12-11  8:08 [PATCH] staging: lustre: This patch fixes the following sparse warning: Jandy Gou
@ 2015-12-21 23:45 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-12-21 23:45 UTC (permalink / raw)
  To: Jandy Gou
  Cc: oleg.drokin, andreas.dilger, mike.rapoport, jinshan.xiong,
	yawei.niu, lustre-devel, devel, linux-kernel

On Fri, Dec 11, 2015 at 04:08:53PM +0800, Jandy Gou wrote:
> drivers/staging/lustre/lustre/osc/osc_cache.c:622:19: warning: symbol
> 'osc_extent_find' was not declared. Should it be static?
> drivers/staging/lustre/lustre/osc/osc_cache.c:1423:6: warning: symbol
> 'osc_unreserve_grant' was not declared. Should it be static?
> 
> Signed-off-by: Jandy Gou <qingsong.gou@ck-telecom.com>
> ---
>  drivers/staging/lustre/lustre/osc/osc_cache.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

The subject is very odd, please fix it up to be more like other commits
are (look in the history of the file for specifics...)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-21 23:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-11  8:08 [PATCH] staging: lustre: This patch fixes the following sparse warning: Jandy Gou
2015-12-21 23:45 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®