mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: wuninsu@gmail.com
Cc: Dept-GELinuxNICDev@qlogic.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, taesoo@gatech.edu,
	yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu
Subject: Re: [PATCH] qlcnic: correctly handle qlcnic_alloc_mbx_args
Date: Tue, 29 Dec 2015 14:46:15 -0500 (EST)	[thread overview]
Message-ID: <20151229.144615.1025537000748350969.davem@davemloft.net> (raw)
In-Reply-To: <1451417387-11321-1-git-send-email-wuninsu@gmail.com>

From: Insu Yun <wuninsu@gmail.com>
Date: Tue, 29 Dec 2015 14:29:47 -0500

> Signed-off-by: Insu Yun <wuninsu@gmail.com>
> ---
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
> index a5f422f..a9a2c33 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
> @@ -772,8 +772,10 @@ int qlcnic_82xx_config_intrpt(struct qlcnic_adapter *adapter, u8 op_type)
>  	int i, err = 0;
>  
>  	for (i = 0; i < ahw->num_msix; i++) {
> -		qlcnic_alloc_mbx_args(&cmd, adapter,
> +		err = qlcnic_alloc_mbx_args(&cmd, adapter,
>  				      QLCNIC_CMD_MQ_TX_CONFIG_INTR);

You must fix the indentation of the second line of the function call when
you made changes like this.  The first character on the second line of the
call must be exactly at the first column after the openning parenthesis of
the first line.

You must must the appropriate number of TAB and then SPACE characters
necessary to achieve this.

Thanks.

  reply	other threads:[~2015-12-29 19:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-29 19:29 Insu Yun
2015-12-29 19:46 ` David Miller [this message]
2015-12-29 20:02 Insu Yun
2016-01-04 22:14 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151229.144615.1025537000748350969.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Dept-GELinuxNICDev@qlogic.com \
    --cc=changwoo@gatech.edu \
    --cc=insu@gatech.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=taesoo@gatech.edu \
    --cc=wuninsu@gmail.com \
    --cc=yeongjin.jang@gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®