From: Christoph Hellwig <hch@infradead.org>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, nbd-general@lists.sourceforge.net,
kernel@pengutronix.de, Oleg Nesterov <oleg@redhat.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2/5] nbd: Remove signal usage
Date: Sun, 3 Jan 2016 03:56:31 -0800 [thread overview]
Message-ID: <20160103115630.GA9803@infradead.org> (raw)
In-Reply-To: <1451729825-11481-3-git-send-email-mpa@pengutronix.de>
Hi Markus,
this looks great!
Reviewed-by: Christoph Hellwig <hch@lst.de>
One thing I noticed, which might be a good cleanup in the future:
> - spin_lock_irqsave(&nbd->tasks_lock, flags);
> nbd->task_recv = current;
> - spin_unlock_irqrestore(&nbd->tasks_lock, flags);
It seems like task_{send,recv} are only used for the files showing
the pids. Maybe you should just store the pids directly in the
nbd_device structure and also keep the sysfs file around for the
life time of that structure.
next prev parent reply other threads:[~2016-01-03 11:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-02 10:17 [PULL] NBD changes Markus Pargmann
2016-01-02 10:17 ` [PATCH 1/5] nbd: Fix debugfs error handling Markus Pargmann
2016-01-02 11:49 ` [PATCH] nbd: fix ifnullfree.cocci warnings kbuild test robot
2016-01-02 11:49 ` [PATCH 1/5] nbd: Fix debugfs error handling kbuild test robot
2016-01-02 10:17 ` [PATCH 2/5] nbd: Remove signal usage Markus Pargmann
2016-01-03 11:56 ` Christoph Hellwig [this message]
2016-01-02 10:17 ` [PATCH 3/5] nbd: Timeouts are not user requested disconnects Markus Pargmann
2016-01-02 10:17 ` [PATCH 4/5] nbd: Cleanup reset of nbd and bdev after a disconnect Markus Pargmann
2016-01-02 10:17 ` [PATCH 5/5] nbd: Move flag parsing to a function Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160103115630.GA9803@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=nbd-general@lists.sourceforge.net \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome