From: Steven Rostedt <rostedt@goodmis.org>
To: Petri Gynther <pgynther@google.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: v4.4-rc8: compile warning in scripts/recordmcount.c
Date: Mon, 4 Jan 2016 15:52:13 -0500 [thread overview]
Message-ID: <20160104155213.33dd3f05@gandalf.local.home> (raw)
In-Reply-To: <CAGXr9JHYg=izGcz7Jzjyye3UCCbDhSvSTOZbFHv6-xOTeF8p+w@mail.gmail.com>
On Mon, 4 Jan 2016 12:22:58 -0800
Petri Gynther <pgynther@google.com> wrote:
> vmlinux: scripts/recordmcount.c: In function ‘main’:
> vmlinux: scripts/recordmcount.c:589:4: warning: format not a string
> literal and no format arguments [-Wformat-security]
> vmlinux: sprintf("%s: failed\n", file);
>
> Introduced by commit:
> commit a50bd43935586420fb75f4558369eb08566fac5e
> Author: Steven Rostedt (Red Hat) <rostedt@goodmis.org>
> Date: Tue Dec 15 16:06:10 2015 -0500
>
> ftrace/scripts: Have recordmcount copy the object file
>
>
> Should that sprintf() be converted to fprintf(stderr, ...) instead?
I'm currently testing this patch:
http://lkml.kernel.org/r/1451516801-16951-1-git-send-email-colin.king@canonical.com
Seems my older gcc (and Fengguang Wu's gcc for his test box) doesn't
catch this.
-- Steve
prev parent reply other threads:[~2016-01-04 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 20:22 Petri Gynther
2016-01-04 20:52 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104155213.33dd3f05@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®