v4.4-rc8: compile warning in scripts/recordmcount.c

v4.4-rc8: compile warning in scripts/recordmcount.c

[Petri Gynther]

vmlinux: scripts/recordmcount.c: In function ‘main’:
vmlinux: scripts/recordmcount.c:589:4: warning: format not a string
literal and no format arguments [-Wformat-security]
vmlinux:     sprintf("%s: failed\n", file);

Introduced by commit:
commit a50bd43935586420fb75f4558369eb08566fac5e
Author: Steven Rostedt (Red Hat) <rostedt@goodmis.org>
Date:   Tue Dec 15 16:06:10 2015 -0500

    ftrace/scripts: Have recordmcount copy the object file


Should that sprintf() be converted to fprintf(stderr, ...) instead?

Re: v4.4-rc8: compile warning in scripts/recordmcount.c

[Steven Rostedt]

On Mon, 4 Jan 2016 12:22:58 -0800
Petri Gynther <pgynther@google.com> wrote:

> vmlinux: scripts/recordmcount.c: In function ‘main’:
> vmlinux: scripts/recordmcount.c:589:4: warning: format not a string
> literal and no format arguments [-Wformat-security]
> vmlinux:     sprintf("%s: failed\n", file);
> 
> Introduced by commit:
> commit a50bd43935586420fb75f4558369eb08566fac5e
> Author: Steven Rostedt (Red Hat) <rostedt@goodmis.org>
> Date:   Tue Dec 15 16:06:10 2015 -0500
> 
>     ftrace/scripts: Have recordmcount copy the object file
> 
> 
> Should that sprintf() be converted to fprintf(stderr, ...) instead?

I'm currently testing this patch:

http://lkml.kernel.org/r/1451516801-16951-1-git-send-email-colin.king@canonical.com

Seems my older gcc (and Fengguang Wu's gcc for his test box) doesn't
catch this.

-- Steve