From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: will.deacon@arm.com, jolsa@kernel.org,
takahiro.akashi@linaro.org, guohanjun@huawei.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
pi3orama@163.com, Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [RFC PATCH v2] perf test: Improve bp_signal
Date: Tue, 5 Jan 2016 11:07:08 +0100 [thread overview]
Message-ID: <20160105100708.GA29394@krava.brq.redhat.com> (raw)
In-Reply-To: <1451987875-15893-1-git-send-email-wangnan0@huawei.com>
On Tue, Jan 05, 2016 at 09:57:55AM +0000, Wang Nan wrote:
> Will Deacon [1] has some question on patch [2]. This patch improves
> test__bp_signal so we can test:
>
> 1. A watchpoint and a breakpoint that fire on the same instruction
> 2. Nested signals
>
> Test result:
>
> On x86_64 and ARM64 (result are similar with patch [2] on ARM64):
>
> # ./perf test -v signal
> 17: Test breakpoint overflow signal handler :
> --- start ---
> test child forked, pid 10213
> count1 1, count2 3, count3 2, overflow 3, overflows_2 3
> test child finished with 0
> ---- end ----
> Test breakpoint overflow signal handler: Ok
>
> So at least 2 cases Will doubted are handled correctly.
>
> [1] http://lkml.kernel.org/g/20160104165535.GI1616@arm.com
> [2] http://lkml.kernel.org/g/1450921362-198371-1-git-send-email-wangnan0@huawei.com
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>
> v1 -> v2: Improve readability, fix typo. Thanks to Jiri Olsa.
>
> To Jiri: I guess you will be okay to provide your SOB for your code at [3],
> so I add it in this v2 patch.
sure, patch looks good to me
thanks,
jirka
prev parent reply other threads:[~2016-01-05 10:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 8:52 [RESEND PATCH] arm64: Store breakpoint single step state into pstate Wang Nan
2015-12-23 10:44 ` kbuild test robot
2015-12-24 1:42 ` [PATCH v2] " Wang Nan
2016-01-04 16:55 ` Will Deacon
2016-01-05 1:41 ` Wangnan (F)
2016-01-05 4:58 ` [RFC PATCH] arm64: perf test: Improbe bp_signal Wang Nan
2016-01-05 5:09 ` Wangnan (F)
2016-01-05 8:53 ` Jiri Olsa
2016-01-05 9:00 ` Jiri Olsa
2016-01-05 9:05 ` Jiri Olsa
2016-01-05 9:09 ` Jiri Olsa
2016-01-05 5:06 ` [PATCH v2] arm64: Store breakpoint single step state into pstate Wangnan (F)
2016-01-12 17:06 ` Will Deacon
2016-01-15 8:20 ` xiakaixu
2016-01-21 8:06 ` xiakaixu
2016-01-18 11:39 ` Wangnan (F)
2016-01-05 9:57 ` [RFC PATCH v2] perf test: Improve bp_signal Wang Nan
2016-01-05 10:07 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105100708.GA29394@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=guohanjun@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pi3orama@163.com \
--cc=takahiro.akashi@linaro.org \
--cc=wangnan0@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome